Repository navigation
Fix remaining 3 test failures: Quaternion transpose and VariableDatum padding - #43
Merged
Merged
Conversation
…m padding fix Quaternion.setMat3 used Chrenshaw's transposed matrix convention but the code never transposed the input, producing transposed output from getMat3 round-trips. Swap the anti-symmetric matrix element pairs to match getMat3's convention (Vince pg 202). Re-apply VariableDatum.getMarshalledSize() padding fix that was overwritten by a full rebuild from the source generator. Closes #34, closes #36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 3 remaining test failures Don reported after the initial round of fixes.
Quaternion.setMat3 transpose bug (2 failures):
setMat3()used Chrenshaw's formula which expects a transposed matrix (the comment even says "he transposes m!") but never transposed the inputMatrix→Quaternion→Matrixround-trip produced the transpose of the originalgetMat3's convention (Vince pg 202)testMatrix3fRoundTripandtestMatrix4fRoundTripnow passVariableDatum padding (1 failure):
padding.length(which is 0 before marshaling)Closes #34, closes #36
Test plan