Repository navigation
fix(record): remove duplicated header written by StandardVariableRecord.serialize - #90
Open
ngjunsiang wants to merge 1 commit into
Open
ngjunsiang wants to merge 1 commit into
ngjunsiang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
StandardVariableRecord.serializehas a concrete abstract-method body that writesrecordType(u32) +recordLength(u32), while every concrete subclass writes its ownrecordTypeu32 +recordLengthu16 header after callingsuper().serialize()— so serialized SV records carry 8 duplicated header bytes andrecordLengthunder-reports the record size (e.g.DirectedEnergyDamage:marshalledSize()40,serialize()emits 48), andparse— which expects the single 6-byte header — misaligns on self-produced output.Fix: reduce
StandardVariableRecord.serializeto a docstring-only abstract method so subclasses own the §6.2.83 header; no production behavior other than removing the duplicated bytes.Fixes #89.
Adds regression test
tests/test_StandardVariableRecord.py(serialized length == marshalledSize == recordLength).