Add skip_all option for checks and check collections - #28
Open
rmm5t wants to merge 1 commit into
Open
Conversation
dgarwood
reviewed
Sep 8, 2026
Comment on lines
+151
to
157
| it "omits checks registered with skip_all" do | ||
| foocheck.skip_all = true | ||
| default_collection.register(:foo, foocheck) | ||
| default_collection.register(:bar, barcheck) | ||
| allow(barcheck).to receive(:to_text) { "bar" } | ||
| expect(default_collection.to_text).to eq("foo collection name\n\s\sbar") | ||
| end |
Contributor
There was a problem hiding this comment.
is it possible that this passes because we have only the one allow? same question for the other tests like this. basically, what happens with this test if we include an allow(foocheck).to receive(:to_text) {"foo"}? If this is skipped, I'd expect that we get the expected output on line 156 and this test would pass.
Contributor
Author
There was a problem hiding this comment.
Good point. The test currently fails if the skipped check is included because its real output adds another line, but that relies unnecessarily on Check#to_text. I’ll stub both checks and add a negative expectation for the skipped check. I’ll make the equivalent assertions for JSON and success status as well.
rmm5t
force-pushed
the
rmm/skip-all-option
branch
from
September 8, 2026 21:07
db9278f to
a5d5102
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
skip_all: trueregistration option for checks that should remain directly accessible without running as part of/okcomputer/all.This also enables independently addressable groups of checks:
The version checks are available through
/okcomputer/versionsand their individual endpoints, but are omitted from/okcomputer/all.Implementation
skip_allattribute to checks and check collections.skip_all.Testing
461 examples, 0 failures./cc @dgarwood