Repository navigation
nipcash: wait for the reply subscription before sending the request - #129
Merged
Merged
Conversation
added 2 commits
October 17, 2026 13:23
The reply subscription and the request travel on separate connections, so a relay could take the request first and deliver the hub's reply to no one; the client then waited out not_after for an answer that had been sent. Seen once in the v0.5.0-rc.24 release run. The send now waits for the relay's EOSE on the subscription, at most two seconds, before publishing. The test relays send EOSE as real relays do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
not_afterfor an answer that had been sent.Seen once in the v0.5.0-rc.24 release run (
TestAuditDPrivacy_TimingPairsRequestAndReplytimed out); not reproduced locally in 40 runs under load, so the new test reproduces it deterministically instead.Test plan
go vet,go mod tidy, gofmt,go test -race -count=1 ./nipcash/...; nipcash/client back to ~2.7 s