Repository navigation
nipcash, nipcw: client-side request checks, resend safety, and the remaining test gaps - #125
Merged
Merged
Conversation
added 10 commits
October 14, 2026 17:24
naliyi
marked this pull request as ready for review
October 14, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124
Summary
mint_cash, aconnection_keywithoutia_pubkey, a negative or sub-second expiry, duplicate consolidate sources and a nil transfer target (previously a panic).ItemOutcome.SafeToResendis false for a Hub success the client could not decode (newUndecodableflag).BatchSession's*Manymethods refuse a bill minted by another node instead of sending it into silence.Test plan
go vet,go mod tidy, gofmt, golangci-lint v2.13.2, govulncheck,go test -race -count=1 ./...nipcash/clientrace suite run three times concurrently on a loaded machine: green.