Skip to content

nipcash: conformance fixes for provenance, claim checks, envelopes and chunked replies - #121

Merged
naliyi merged 11 commits into
mainfrom
fix/nipcash-conformance
Oct 14, 2026
Merged

naliyi merged 11 commits into
mainfrom
fix/nipcash-conformance

Conversation

@naliyi

@naliyi naliyi commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Closes #120

Summary

  • VerifyProvenance verifies satscash1 tokens under lnd's prefix and reports no provenance for an unknown HRP, instead of a wrong minter.
  • CheckClaim returns nipcash.ErrSpent for a tombstone; CashConsolidate errors on an undecryptable delivery.
  • transport.Decode drops a malformed item into Envelope.Rejected and keeps its co-items; chunked replies bound total by the items requested and keep decided outcomes.
  • Encoders no longer write blank relay entries.
  • Adds frozen known-answer and regression tests for provenance, connection_key, the claim-proof kind, cash-target commitments and bill-proof signing.

Test plan

  • Each fix's regression test fails on main and passes here.
  • Each test-only addition was checked against the mutation it guards (mutant red, reverted green).
  • go vet, go mod tidy, gofmt, golangci-lint v2.13.2, go test -race -count=1 ./...

@naliyi
naliyi marked this pull request as ready for review October 14, 2026 11:03
@naliyi
naliyi merged commit c73e93f into main Oct 14, 2026
3 checks passed
@naliyi
naliyi deleted the fix/nipcash-conformance branch October 17, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nipcash: conformance fixes for provenance, claim checks, envelopes and chunked replies

1 participant