Repository navigation
huddle: forward subscriber keyframe requests to the publisher - #151
Merged
Merged
Conversation
The SFU discarded each subscriber's RTPSender and never read its RTCP, so PLI/FIR never reached the publisher and pion's NACK responder never ran. Browsers only encode a keyframe when asked, so one lost packet froze a forwarded picture for good while audio continued. The single keyframe request made at track creation also landed before the subscriber had answered the renegotiation, so that keyframe was dropped by the unbound track. - read RTCP per subscriber track; forward PLI/FIR, throttled to 500ms - request a keyframe on the subscriber's first RTCP (track now bound) - request one when a publisher reconnects onto the same track ids - record the subscription only after AddTrack succeeds Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes huddle video freezing after a lost packet on
ncli relay. The SFU dropped each subscriber's RTPSender and never read its RTCP, so PLI/FIR never reached the publisher and NACKs went unanswered.CHANGELOG section is headed
[0.8.0-rc.23]for the next RC.