fix: surface workspace deletion errors - #105
Open
utpalsinghdev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honcho returns 409 when a workspace still has sessions, with a detail like
Cannot delete workspace '<name>': active session(s) remain. Delete all sessions first.The Delete Workspace modal stayed open and showed none of that, so confirm looked like it did nothing.This PR shows that API
detailstring in the modal. If the response has no usable detail, it shows a short fallback. Failed deletes keep the modal open so you can cancel or retry. A successful delete still goes to/workspaces. Cancel and reopen clear the last error.Type
Test plan
pnpm lintpassespnpm testpasses@openconcho/webbuild succeedsRelated issues
Closes #73