feat: make workspace title link to overview - #104
Open
utpalsinghdev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From a workspace page like Peers, the only ways back to the workspace overview were the Workspaces list or the breadcrumb. The selected workspace ID already appears in the left sidebar, but it was plain text.
This PR turns that sidebar label into a link to
/workspaces/$workspaceId. Visible text and the tooltip still go through demo-mode masking. The route param uses the real workspace id.Type
Test plan
pnpm lintpassespnpm testpasses@openconcho/webbuild succeeds/workspaces/ws-alpha/peersws-alphawas a visible link to/workspaces/ws-alpha********) and the raw id was not in page text. The href still usedws-alpha.Related issues
Closes #87