feat: warn when Honcho token is missing - #103
Open
utpalsinghdev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I pointed OpenConcho at a Honcho instance and left the token blank. The app loaded in a half-working state: workspaces showed up, conclusions failed, and nothing said the token was missing.
The health check already maps 401/403 to
auth-required. That only showed as a small sidebar dot (hover tooltip, hidden on a narrow sidebar). This PR adds a layout banner for the missing-token case: the instance requires a token, none is configured, and Settings is one click away. Public self-hosted instances with no auth still get no warning. The existing health dot is unchanged.Type
Test plan
pnpm lintpassespnpm testpasses@openconcho/webbuild succeeds (tsc -b && vite build)/settingsand the instance listtest-token) cleared the banner. The token never appeared in page text.Related issues
Closes #102
Related to #95, which is about authenticating access to the OpenConcho Web UI. This PR is about the token OpenConcho sends to Honcho.