Repository navigation
Weekly review: fix double entity decoding in page titles - #76
Open
DennisAlund wants to merge 1 commit into
Open
DennisAlund wants to merge 1 commit into
DennisAlund wants to merge 1 commit into
Conversation
Chained replaces decoded "&lt;" twice into "<", and String.fromCharCode split astral references such as 😀 into surrogate halves. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01REGVUtoAAVSPsdGVWCFLsJ
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
shrtnr | f6219d1 | Oct 09 2026, 07:21 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
extractTitle(src/title-fetch.ts).replacecalls decoded&lt;twice (to<), andString.fromCharCodesplit astral references (😀) into surrogate halves.fromCodePoint, out-of-range references left verbatim.src/__tests__/unit/title-fetch.test.ts; both fail before the fix, pass after. Full vitest suite green (1598).Flagged for developer judgment (not changed)
yarn audit --groups dependencies: 2 critical, 28 high, all transitive viaagents>@modelcontextprotocol/sdk> express, ajv > fast-uri, ip-address, proxy-addr).@modelcontextprotocol/sdkis patched in >=1.31.0. Upgradingagents/the MCP SDK is a non-drop-in bump, so left for you. Worth checking whether the Worker bundle actually includes the express paths.src/rate-limit.ts: the in-memory window map never evicts expired entries, so an isolate seeing many distinct client keys grows unbounded until recycled. Low impact on Workers; a periodic sweep would fix it if wanted.yarn e2enot run (no src/pages, admin or client changes).🤖 Generated with Claude Code
https://claude.ai/code/session_01REGVUtoAAVSPsdGVWCFLsJ
Generated by Claude Code