Repository navigation
feat(tracing): forward the journey name alongside the journey id - #115
Merged
Merged
Conversation
When the host stashes a journey name (flask.g.journey_name — set by flask_campus's @Journey decorator or by the journeys middleware adopting X-Journey-Name, campus#952), SDK calls forward it as X-Journey-Name next to X-Journey-ID, so child services' spans tag the same journey_name and journey cards show the label end to end. Refs nyjc-computing/campus#952, campus-api-python#114 (the name will also ride on the process journey once #114 lands).
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs nyjc-computing/campus#952 (the campus-side adoption PR), refs #114 (the name will also ride on the process journey once that lands).
What
When the host stashes a journey name (
flask.g.journey_name— set by flask_campus's@journeydecorator, or by the journeys middleware adoptingX-Journey-Name), SDK calls now forward it asX-Journey-Namenext toX-Journey-ID. Child services' spans tag the samejourney_name, so journey cards show the human label end to end instead of only on the originating service's span.Lockstep:
JOURNEY_NAME_HEADER = "X-Journey-Name"mirrorscampus.audit.middleware.journeys.ACTION_JOURNEY_NAME_HEADER, per the keep-in-lockstep notes both modules already carry forX-Journey-ID.Testing
TestJourneyNameForwarding: name forwarded with the id, no name → no header, and a lockstep pin test on the header constant.