Conversation
An empty link like [[]] parses into a link node without a url field. Collecting links from such a file crashed on reading the missing node instead of ignoring the malformed link. Treat a link node without a url as no link: skip it in the file-level link list and return nil from the cursor lookup, whose callers already handle nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing
[[]]into an org file, for example while starting a link, breaks every caller ofOrgFile:get_links()until the brackets are filled:The grammar still produces a
linknode for the empty brackets, but without aurlfield. Same for[[][desc]].from_nodenow returns nil for a link node without a url.get_linksskips those nodes; theat_cursorcallers already handle nil.