Skip to content

Put genre, title, and artist in one order, and line up the play screen's DJ level - #264

Merged
nulltask merged 4 commits into
develfrom
feature/song-heading-order
Oct 11, 2026
Merged

nulltask merged 4 commits into
develfrom
feature/song-heading-order

Conversation

@nulltask

Copy link
Copy Markdown
Owner

Summary

  • Every built-in skin now heads the song with its genre, then the title, then the artist, on the select, play, and result screens.
    • The play screens' track plates move the genre from the right end of the artist line to a small line above the title.
    • Plain's select screen moves the genre above the title, and its result screen gains the genre.
    • Synesthesia, Lattice, and Phantom results move the genre from under the artist to above the title.
  • Synesthesia, Lattice, and Phantom drew the play screen's rank letter (F to AAA) below the RANK label's row. It is now centred on the label's row, and Phantom's badge sits inside the score plate instead of breaking out of its lower corner.

Long titles are still squeezed to fit; scrolling them instead comes in a follow-up.

Test plan

  • Typecheck and the skin tests
  • Screenshots of select, play, and result for all four skins, with a chart whose title, artist, and genre are very long

🤖 Generated with Claude Code

…e built-in skins

Every built-in skin now heads the song with its genre, then the title, then the artist, on the select, play, and result screens. The play screens' track plates move the genre from the artist line to a small line above the title, and Plain's result screen gains the genre.
Synesthesia, Lattice, and Phantom drew the rank letter below the RANK label's row (Phantom's badge broke out of the plate's lower corner). The letter is now centred on the label's row, and Phantom's badge sits inside the plate.
@nulltask
nulltask force-pushed the feature/song-heading-order branch from 08c8d8d to 5f76923 Compare October 11, 2026 11:56
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
be-music-player-demo 3d65fe5 Commit Preview URL

Branch Preview URL
Oct 11 2026, 11:58 AM

… rail

The rule under the lanes started at the left rail's outer edge but was four design pixels wider than the well, so it ran past the right rail's outer edge.
@github-actions

Copy link
Copy Markdown

Exports Benchmark

  • Base SHA: 67dbf697b68f
  • Head SHA: 3d65fe50b5ab
  • Comparable cases: 91
  • Regression threshold: 8.00%
  • Overall verdict uses the median change across cases.
  • Per-case lists compare median ops/s, not mean.
  • Base runs: median of 3
  • Head runs: median of 3

Summary

Metric Value
Overall unchanged
Median change +0.24%
Mean change +0.32%
Cases improved (>= threshold) 1
Cases regressed (<= -threshold) 0
Cases unchanged 90
Cases excluded (sub-timer-resolution) 212
Head benchmarked cases 303
Head skipped cases 21

Top Regressions

No regression over threshold.

Top Improvements

API Base median ops/s Head median ops/s Change
player-web.BrowserSongCollectionStore 10622.20 11534.69 +8.59%

Excluded (sub-timer-resolution)

Per-call latency at or below 0.001ms on at least one side — the reported time is measurement noise, not the case's real cost, so no percent change is shown.

API Base median ops/s Head median ops/s
audio-renderer.createTimingBuildContext 1923076.92 1923076.94
chart.compareEvents 10416666.69 10416666.69
chart.createBeatResolver 20833332.60 20833332.60
chart.eventToBeat 13888889.10 13888889.10
chart.exWavVolumeCentibelsToLinearGain 15625000.04 15625000.04
chart.getMeasureBeats 20833332.60 20833332.60
chart.isBmsBgmVolumeChangeChannel 17857142.61 17857142.61
chart.isBmsDynamicVolumeChangeChannel 17857142.61 15625000.04
chart.isBmsKeyVolumeChangeChannel 17857142.61 17857142.61
chart.isBmsLongNoteChannel 20833332.60 20833332.60
chart.isLandmineChannel 20833332.60 20833332.60
chart.isPlayableChannel 20833332.60 20833332.60

@nulltask
nulltask merged commit 6ff4f55 into devel Oct 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant