Skip to content

style: update the width of history dropdown #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btea wants to merge 1 commit into
base: main
Choose a base branch
from
Open

style: update the width of history dropdown #1077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/react/src/html/ui/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,12 @@ main {
div[role='menu'] {
left: 0;

/* Shrink the dropdown to fit its content instead of the fixed
* width set by @node-core/ui-components (nodejs/doc-kit#1051) */
width: fit-content;
min-width: 12rem;
max-width: 20rem;
Comment on lines +125 to +129

@avivkeller avivkeller Sep 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we update this in ui-components?

@btea btea Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure whether to make uniform changes within the component or to implement targeted changes within projects that use the component.

@ovflowd ovflowd Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO should be on ui-components itself too!


/* Prevent long labels from overflowing dropdown width */
a[role='menuitem'] div {
overflow-wrap: anywhere;
Expand Down
Loading