Skip to content

[Android] release native handles before their callback data #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
myungjoo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Android] release native handles before their callback data #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
068f44b
[Android] release native handles before their callback data
myungjoo Sep 14, 2026
588353f
[Test] cover the teardown order of the Android binding
myungjoo Sep 14, 2026
f9a3b55
[Android] record why the pipe info is kept on an unregister failure
myungjoo Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
235 changes: 233 additions & 2 deletions java/android/nnstreamer/src/androidTest/java/org/nnsuite/nnstreamer/APITestCustomFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
*/
@RunWith(AndroidJUnit4.class)
public class APITestCustomFilter {
private int mReceived = 0;
private boolean mInvalidState = false;
private volatile int mReceived = 0;
private volatile boolean mInvalidState = false;
private boolean mRegistered = false;
private CustomFilter mCustomPassthrough;
private CustomFilter mCustomConvert;
Expand Down Expand Up @@ -396,4 +396,235 @@ public TensorsData invoke(TensorsData in) {
/* expected */
}
}

@Test
public void testCloseWhileUsed_n() {
TensorsInfo inputInfo = new TensorsInfo();
inputInfo.addTensorInfo(NNStreamer.TensorType.INT32, new int[]{10});

TensorsInfo outputInfo = inputInfo.clone();

CustomFilter filter = CustomFilter.create("custom-close-while-used-n",
inputInfo, outputInfo, new CustomFilter.Callback() {
@Override
public TensorsData invoke(TensorsData in) {
return in;
}
});

String desc = "appsrc name=srcx ! " +
"other/tensor,dimension=(string)10,type=(string)int32,framerate=(fraction)0/1 ! " +
"tensor_filter framework=custom-easy model=" + filter.getName() + " ! " +
"tensor_sink name=sinkx";

try (Pipeline pipe = new Pipeline(desc)) {
/* filter is referenced by the pipeline: close() must fail */
mInvalidState = false;
try {
filter.close();
mInvalidState = true;
} catch (IllegalStateException e) {
/* expected */
}

assertFalse(mInvalidState);

/* the filter must still be registered and usable */
pipe.registerSinkCallback("sinkx", new Pipeline.NewDataCallback() {
@Override
public void onNewDataReceived(TensorsData data) {
if (data == null || data.getTensorsCount() != 1) {
mInvalidState = true;
return;
}

ByteBuffer output = data.getTensorData(0);

for (int j = 0; j < 10; j++) {
if (output.getInt(j * 4) != j) {
mInvalidState = true;
}
}

mReceived++;
}
});

/* start pipeline */
pipe.start();

/* push input buffer repeatedly */
for (int i = 0; i < 10; i++) {
TensorsData in = TensorsData.allocate(inputInfo);
ByteBuffer input = in.getTensorData(0);

for (int j = 0; j < 10; j++) {
input.putInt(j * 4, j);
}

in.setTensorData(0, input);

pipe.inputData("srcx", in);
Thread.sleep(20);
}

/* sleep 300 to pass all input buffers to sink */
Thread.sleep(300);

/* stop pipeline */
pipe.stop();

/* check received data from sink */
assertFalse(mInvalidState);
assertEquals(10, mReceived);
} catch (Exception e) {
fail();
}

/* the pipeline is closed now: close() should succeed */
try {
filter.close();
} catch (Exception e) {
fail();
}

/* the name is really unregistered, a new filter with the same name should succeed */
try {
CustomFilter again = CustomFilter.create(filter.getName(),
inputInfo, outputInfo, new CustomFilter.Callback() {
@Override
public TensorsData invoke(TensorsData in) {
return in;
}
});

again.close();
} catch (Exception e) {
fail();
}
}

@Test
public void testCloseAfterPipeline() {
TensorsInfo inputInfo = new TensorsInfo();
inputInfo.addTensorInfo(NNStreamer.TensorType.INT32, new int[]{10});

TensorsInfo outputInfo = inputInfo.clone();

CustomFilter filter = CustomFilter.create("custom-close-after-pipeline",
inputInfo, outputInfo, new CustomFilter.Callback() {
@Override
public TensorsData invoke(TensorsData in) {
return in;
}
});

String desc = "appsrc name=srcx ! " +
"other/tensor,dimension=(string)10,type=(string)int32,framerate=(fraction)0/1 ! " +
"tensor_filter framework=custom-easy model=" + filter.getName() + " ! " +
"tensor_sink name=sinkx";

/* construct and close a pipeline using the filter */
try (Pipeline pipe = new Pipeline(desc)) {
/* nothing to do here */
} catch (Exception e) {
fail();
}

/* the pipeline no longer references the filter, close() should succeed */
try {
filter.close();

CustomFilter again = CustomFilter.create(filter.getName(),
inputInfo, outputInfo, new CustomFilter.Callback() {
@Override
public TensorsData invoke(TensorsData in) {
return in;
}
});

again.close();
} catch (Exception e) {
fail();
}
}

@Test
public void testCloseTwice() {
TensorsInfo inputInfo = new TensorsInfo();
inputInfo.addTensorInfo(NNStreamer.TensorType.INT32, new int[]{10});

TensorsInfo outputInfo = inputInfo.clone();

CustomFilter filter = CustomFilter.create("custom-close-twice",
inputInfo, outputInfo, new CustomFilter.Callback() {
@Override
public TensorsData invoke(TensorsData in) {
return in;
}
});

try {
/* not used by any pipeline, close() should succeed */
filter.close();

/* closing an already closed filter is a no-op */
filter.close();

CustomFilter again = CustomFilter.create(filter.getName(),
inputInfo, outputInfo, new CustomFilter.Callback() {
@Override
public TensorsData invoke(TensorsData in) {
return in;
}
});

again.close();
} catch (Exception e) {
fail();
}
}

@Test
public void testCloseWhileUsedNotStarted_n() {
TensorsInfo inputInfo = new TensorsInfo();
inputInfo.addTensorInfo(NNStreamer.TensorType.INT32, new int[]{10});

TensorsInfo outputInfo = inputInfo.clone();

CustomFilter filter = CustomFilter.create("custom-close-while-used-not-started-n",
inputInfo, outputInfo, new CustomFilter.Callback() {
@Override
public TensorsData invoke(TensorsData in) {
return in;
}
});

String desc = "appsrc name=srcx ! " +
"other/tensor,dimension=(string)10,type=(string)int32,framerate=(fraction)0/1 ! " +
"tensor_filter framework=custom-easy model=" + filter.getName() + " ! " +
"tensor_sink name=sinkx";

try (Pipeline pipe = new Pipeline(desc)) {
/* the pipeline is never started, but the filter is still referenced */
mInvalidState = false;
try {
filter.close();
mInvalidState = true;
} catch (IllegalStateException e) {
/* expected */
}

assertFalse(mInvalidState);
} catch (Exception e) {
fail();
}

/* the pipeline is closed now: close() should succeed */
try {
filter.close();
} catch (Exception e) {
fail();
}
}
}
Loading
Loading