Repository navigation
ci: deploy typing to npm and JSR from GitHub Releases - #462
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 52 52
Lines 3057 3057
Branches 327 327
=======================================
Hits 3010 3010
Misses 46 46
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gjbkz
commented
Oct 13, 2026
gjbkz
left a comment
Member
Author
There was a problem hiding this comment.
[Claude · review]
Changes requested. The workflow switch is fine, but the JSR part replaces a one-line npx jsr publish with 360 lines (cli/release-jsr.ts + tests) that mostly re-check what is already guaranteed:
- Drop
cli/release-jsr.ts, its test and therelease:jsr/test:releasescripts. MakePublishJsrrun withneeds: Stage. The shared Stage job already verifies that the tag points atGITHUB_SHAand runsrelease:prepareon that commit.jsr publishskips a version that is already published, so a retry is a no-op without the_meta.jsoncomparison.cli/sync-version.tsalready keepsjsr.jsonin sync withpackage.json. After the change,PublishJsronly needs checkout, setup-node,npm ciandnpx jsr@0.14.3 publish. This also clears the codecov/patch and codecov/project failures, which come from the uncovered new file. release:prepareshrinks tonpm run build && git diff --exit-code -- src(the--checkcall goes away with item 1).- Helper pin: the workflow at
fb8c1ebcalls a helper commit that is not on nlibjs/actionsmain. Re-pinVerifyandStageonce nlibjs/actions re-pins the helper tomain.
Generated by Claude Code
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
gjbkz
commented
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Codex · pr]
Stage npm from a published GitHub Release through the shared workflow, then publish JSR from the same commit after Stage succeeds. JSR does not wait for npm approval; its pinned CLI skips already published versions.
Keep manual Verify and tag-selected retries. Preparation builds the package and checks generated source for uncommitted changes.
Validation: lint, preparation, actionlint, shared caller checks, and CI pass.