Skip to content

ci: deploy typing to npm and JSR from GitHub Releases - #462

Merged
gjbkz merged 4 commits into
mainfrom
ci/shared-npm-release
Oct 13, 2026
Merged

gjbkz merged 4 commits into
mainfrom
ci/shared-npm-release

Conversation

@gjbkz

@gjbkz gjbkz commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

[Codex · pr]

Stage npm from a published GitHub Release through the shared workflow, then publish JSR from the same commit after Stage succeeds. JSR does not wait for npm approval; its pinned CLI skips already published versions.

Keep manual Verify and tag-selected retries. Preparation builds the package and checks generated source for uncommitted changes.

Validation: lint, preparation, actionlint, shared caller checks, and CI pass.

Co-Authored-By: Codex <noreply@openai.com>
@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.46%. Comparing base (15c296e) to head (31c2ad5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          52       52           
  Lines        3057     3057           
  Branches      327      327           
=======================================
  Hits         3010     3010           
  Misses         46       46           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gjbkz gjbkz left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Claude · review]

Changes requested. The workflow switch is fine, but the JSR part replaces a one-line npx jsr publish with 360 lines (cli/release-jsr.ts + tests) that mostly re-check what is already guaranteed:

  1. Drop cli/release-jsr.ts, its test and the release:jsr / test:release scripts. Make PublishJsr run with needs: Stage. The shared Stage job already verifies that the tag points at GITHUB_SHA and runs release:prepare on that commit. jsr publish skips a version that is already published, so a retry is a no-op without the _meta.json comparison. cli/sync-version.ts already keeps jsr.json in sync with package.json. After the change, PublishJsr only needs checkout, setup-node, npm ci and npx jsr@0.14.3 publish. This also clears the codecov/patch and codecov/project failures, which come from the uncovered new file.
  2. release:prepare shrinks to npm run build && git diff --exit-code -- src (the --check call goes away with item 1).
  3. Helper pin: the workflow at fb8c1eb calls a helper commit that is not on nlibjs/actions main. Re-pin Verify and Stage once nlibjs/actions re-pins the helper to main.

Generated by Claude Code

gjbkz and others added 3 commits October 13, 2026 23:07
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>

@gjbkz gjbkz left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude-review: Looks good. No further findings.


Generated by Claude Code

@gjbkz
gjbkz merged commit aca454c into main Oct 13, 2026
8 checks passed
@gjbkz
gjbkz deleted the ci/shared-npm-release branch October 13, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant