Skip to content

Shrink domain object code #5

Description

@whitfin

Currently the domain code is huge, due to builder methods, getters, setters, etc. This makes adding new domain stuff kinda painful. I think that it would be nice if we were to somehow shrink down the code per model.

Activity

  1. changed the title [-]Shrink domain object code using Immutables[/-] [+]Shrink domain object code[/+] on Oct 5, 2017
  2. nightowlengineer commented on Oct 18, 2017

    @nightowlengineer
    Owner

    Agreed for the most part - they were generated with jsonschema2pojo.org so initially creating them was 'trivial', but I can see how adding new attributes wouldn't be as straightforward. Happy to review some changes around this, but not sure how far I'd be willing to go from the current implementation(s) for the sake of LOC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions