Repository navigation
Add command arguments to metadata - #88
Merged
Merged
Conversation
1 of 3 tasks
Mikolaj-A-Kowalski
approved these changes
Jul 15, 2026
Mikolaj-A-Kowalski
left a comment
Mikolaj-A-Kowalski
left a comment
Contributor
There was a problem hiding this comment.
I cannot think of any reason not to include this one. Feels useful.
Contributor
|
Ready to merge? Unless @niravshah241 you want to have another look? |
Contributor
Author
|
@Mikolaj-A-Kowalski thanks I will wait till #87 is also ready and then merge them both. I will take a look at your feedback on the former later today 👌 |
Mikolaj-A-Kowalski
force-pushed
the
remove-neighbour-duplication
branch
from
October 14, 2026 12:33
9e62fcb to
be3a627
Compare
Mikolaj-A-Kowalski
force-pushed
the
add-command-to-metadata
branch
from
October 14, 2026 13:57
72417db to
ddd63db
Compare
Mikolaj-A-Kowalski
changed the base branch from
remove-neighbour-duplication
to
main
October 14, 2026 14:01
Mikolaj-A-Kowalski
force-pushed
the
add-command-to-metadata
branch
2 times, most recently
from
October 14, 2026 14:13
c4c2b61 to
667c70d
Compare
Record all the arguments used to generate the partitioning metadata as a global attribute in the output netCDF file,. This aids reproducibility by documenting the exact arguments used to invoke `decomp`. Co-authored-by: Mikolaj Adam Kowalski <32641577+Mikolaj-A-Kowalski@users.noreply.github.com>
Mikolaj-A-Kowalski
force-pushed
the
add-command-to-metadata
branch
from
October 14, 2026 14:16
667c70d to
7db3ef1
Compare
github-project-automation
Bot
moved this from Review required
to Done
in neXtSIM_DG overview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store command line args in partition metadata netCDF files
Relates to a sub-component of #86
Summary
Adds the decomp tool command line arguments, used to invoke
decompas a globalcommandattribute in all partition metadata netCDF files. This improves reproducibility making it easier to see which argsdecompused to produce a given metadata output.Changes
setArgs()method and_argsmember to store and write the args stringargc/argvarguments string and passes it to the partitioner before saving metadataargsattributeNote
It is not possible to store the MPI launch part e.g.,
mpirun -n 8 decomp ...as is stripped by the launcher. Only thedecomparguments are received bydecomp. As a result we have decided to store args only.