Repository navigation
Harden NXLock release and construction - #273
Merged
Merged
Conversation
- Guard os.close in release() so the lock file is always removed and fd reset - Initialize fd before any exception can be raised in __init__, so __del__ is safe after an invalid lock directory - Return the lock from __enter__ so `with NXLock(f) as lock` binds it - Enforce a minimum 0.1 s polling interval to avoid busy-waiting - Correct the lock_file/fd and is_stale docstrings - Add tests for the constructor failure and context manager; clean up locks left behind by the removal-error tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release()now guardsos.close, so the lock file is always removed andfdreset even if closing failsfdis set before anything in__init__can raise, so__del__no longer hits anAttributeErrorafter an invalid lock directory__enter__returns the lock, sowith NXLock(f) as lockbinds it instead ofNoneacquire()andwait()sleeps at least 0.1 s, socheck_interval=0cannot busy-waitlock_file/fdandis_staledocstringsTests
release(), and a test for the context-manager return value🤖 Generated with Claude Code