Repository navigation
Give the large result export test an explicit time budget - #438
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full-run export test hit the SDK's default ten-second request deadline while reading its 8 MiB payload on main CI. Give this size-limit fixture an explicit one-minute overall/request budget, retain full payload equality and ordinary 4 MiB rejection, and require the wrong-run case to fail for its intended reason. Production timeouts and response limits remain unchanged.
Validation: the unchanged test passed five isolated runs; an injected eleven-second body delay demonstrated the old deadline failure and passed with the fixture correction. With that diagnostic delay removed, export, reader-bound and transport timeout/cancellation tests passed three repetitions. The original CI slowdown itself was not reproduced.