Skip to content

Clients can not join muc room. #8

Description

@johannesk

When a client on a client connection sends a presence with an explicit to jid, and this jid was not previously allowed to receive broadcast presence, the presence is not transmitted. This filtering is done in lib/vines/stanza/presence.rb:45 in revision cb72247.

I have not read the corresponding parts of the RFC, but I am fairly sure this must be wrong. If a client joins a muc(multi user chat) room as in XEP-0045, the client sends a presence to the room. Such a presence to a room is ignored. Therefore a client connected to vines can not join a muc room on any server.

Activity

  1. dgraham commented on Apr 25, 2012

    @dgraham
    Member

    Presence#outbound_broadcast_presence isn't handling directed presence properly as documented in RFC 6121 section 4.6.

    I don't think commit cb72247 is relevant, though. That just added support for some HTTP headers. I think we've just never handled directed presence properly.

    What MUC component are you using to test this?

  2. johannesk commented on Apr 25, 2012

    @johannesk
    Author

    I only mentioned the commit to indicate which version of vines I was using.

    I was not using any real MUC component. To test this, a component which prints stanzas to stdout suffices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions