fix(tui): keep content inside the frame, scroll help, remember settings - #78
Merged
Merged
Conversation
- Wrap indented text, menus, footers and the context path at the rule's right end instead of the terminal edge, and keep the indent when a line only fits without it. - Scroll the ? overlay with the usual keys and show its position. - Put the keys back into footer hints and drop Esc from Home, where it quits rather than going back.
- Return to the entry you left after a submenu, a pick or About. - Ask before restoring defaults, with Cancel preselected. - Report "Icon mode updated" or "Color mode updated" instead of a generic theme message. - Show the author on its own About row instead of after an ASCII colon. - Title-case the settings menu items in English.
Start the logo, tagline and version at the frame's left edge plus the indent, centered with the frame on wide terminals, so nothing jumps when the app opens. Keep the final frame on screen for 400 ms; any key still skips it.
Use "Log in" and "Log out" in every English string, matching the `login`/`logout` commands, and write "第 2 教学周" like "第 13 期".
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A second audit found text running past the frame's rule at ≤83 columns, a help overlay that couldn't scroll, and settings that forgot where you were.
bodyEdgeintheme.ts); lines never lose their indent, they wrap. Below 40 columns text and rule both use the full width.?overlay scrolls with the usual keys, shows a percentage, andqquits from it; the Schedulee/xrows are reachable at 80×24.