feat(push-panel): add a local page for editing push rules - #63
Merged
Merged
Conversation
The page binds to loopback and writes the live plugin config, so the next push uses the saved routes. Tokens and model keys stay out of the page.
Routing no longer decides whether the config is written. The save handler refuses the request until the token matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.json, so the next push uses the new rules. Empty token means the page does not listen. Model keys, bridge tokens, and other secrets are not shown or accepted.Test plan
dotnet test src/HuaJiBot.NET.UnitTest --filter FullyQualifiedName~PushPanelTest(5 tests: route update, rejected group, rejected bridge address, read of the other rules, HTTP 401 and save)http://127.0.0.1:8787/through an SSH tunnel and confirm the current routes load