Bump moonbitlang/async to 0.22.4 - #190
Merged
Merged
Conversation
async 0.22.0 changed cancellation semantics (catch no longer captures cancellation; TaskGroup::add_defer needs a nocancel callback). The catch sites in cmd/moonfmt and cmd/mq only convert errors into messages/exit codes, and the test temp-dir cleanup already uses add_defer + protect_from_cancel, so no code changes are needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Automated review by Codex CLI: No actionable findings.
VERDICT: APPROVE CI green. Merging as a low-risk dependency bump; a release follows. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
moonbitlang/asyncto 0.22.4 (latest).Since async 0.22.0,
catchno longer captures cancellation; cleanup must live indefer/errdefer. This PR bumps the dependency and audits everycatcharound async code.Change: Bump moonbitlang/async 0.21.2 → 0.22.4 (root module; lexer and moon_config don't use async). No source changes.
Cancellation audit: 10
catchsites in cmd/mq and cmd/moonfmt reviewed; each converts an error to a message and exit or ignores a failed stderr write. None changed. The existingadd_deferalready passes aprotect_from_cancelcallback.Verification: Identical before and after: root 2754 (wasm-gc, js), 2759 (native), 2757 (wasm); workspace 2835/2840/2838; lexer 23, moon_config 58 on all targets.
Commits:
🤖 Generated with Claude Code