feat(vue): Salvage PrimeVue barrel, cache-bust, and i18n - #702
Open
Ibochkarev wants to merge 1 commit into
Open
Conversation
Import PrimeVue from the VueTools barrel so manager screens share one Theme instance. Reject primevue/* subpaths at Vite build time, bust vue-dist cache with filemtime, and keep Aura as the default preset. ModxManagerTheme and getActiveTheme stay out until vueTools#22. Fixes #701
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Из закрытого PR #640 в менеджер переносятся куски, которые не зависят от Modx-темы: named-импорты
import { X } from 'primevue'вместоprimevue/*, Vite-плагинrejectPrimeVueSubpaths, cache-bust vue-модулей поfilemtime(vue_module_cache_bust.inc.php), лексиконы ru/en для help, истории заказа, VendorCombo и Uppy Image Editor.Тема остаётся Aura (
preset: Aura,darkModeSelector: none) на VueTools 1.1.2-pl. Плотность контролов,severity="success"на Save и CSS с токенамиmodx.*сюда не входят. Без централизованной темы из vueTools#22 они ломают дефолтную Aura.Тип изменений
Связанные Issues
Closes #701
Связано: #640, vueTools#22
Как это было протестировано?
composer ci:phpи PHPStan по этому diff не гонялись: PHP-слой это include и три вызова вaddVueModule. Менеджер в браузере не проверялся.composer ci:php/composer test,npm run lint:ci,composer stan/ GitHub Actions CI)Конфигурация тестирования:
feat/issue-701-primevue-barrelСкриншоты (если применимо)
Не применимо. Критерий #701: менеджер визуально как текущая Aura.
Чеклист
composer stan/ CI jobPHPStan)npm run lint:ciдля Vue)Дополнительные заметки
getActiveTheme(), theme-aware плотность/CSS, проверкаimports['vuetools/theme']) ждёт vueTools#22.1.1.2-pl.yes/noвместо захардкоженных «Да» / «Нет».