Migrate vueManager node tests to vitest behavior checks - #693
Open
Ibochkarev wants to merge 1 commit into
Open
Conversation
Source-grep tests missed equivalent refactors that restored double confirm and ungrouped ConfirmDialog. Mount settings grids and assert isolation plus a single delete request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Четыре теста в
vueManager/tests/гонялись черезnode --testи читали.vueкак текст. Такой тест ловит откат строки и пропускает переименование или выносconfirm.requireв хелпер. Набор переехал на vitest: гриды монтируются, чистые функции остались проверками логики.vueManager/tests/удалён.npm run test:smokeоставляет толькоscripts/check-ui-group-smoke.mjs(#539, без DOM). Шаг Smoke tests в CI сохранён.Тип изменений
Связанные Issues
Closes #692
Как это было протестировано?
npm test,npm run lint:ci,npm run test:smoke)Конфигурация тестирования:
test/issue-692-vitest-behaviorvueManagerСкриншоты (если применимо)
Чеклист
composer stan/ CI jobPHPStan)npm run lint:ciдля Vue)Дополнительные заметки
settingsConfirmDialog.test.jsмонтирует все 7 settings-гридов: уникальныйConfirmDialog.group, изоляция Options+Groups на одной странице (#548), одиночныйrequest.deleteпосле accept в пяти ActionsColumn-гридах (#630).