Skip to content

ci: линтить JS витрины (assets/.../js/web) - #668

Open
Ibochkarev wants to merge 1 commit into
betafrom
fix/issue-667-storefront-eslint
Open

ci: линтить JS витрины (assets/.../js/web)#668
Ibochkarev wants to merge 1 commit into
betafrom
fix/issue-667-storefront-eslint

Conversation

@Ibochkarev

Copy link
Copy Markdown
Member

Описание

CI-job vueManager lint теперь отдельно прогоняет ESLint по assets/components/minishop3/js/web/** (npm run lint:storefront, --max-warnings 0). Конфиг — plain <script> с browser-глобалями; lib/izitoast игнорируется. Накопившиеся замечания разобраны (comma-dangle, unused catch, debug console.log).

Пакеты @eslint/js / globals резолвятся из vueManager/node_modules через createRequire (в CI нет корневого node_modules).

Тип изменений

  • Исправление бага (non-breaking change)

Связанные Issues

Closes #667

Как это было протестировано?

cd vueManager
npm run lint:ci          # exit 0
npm run lint:storefront  # exit 0
  • Автоматические тесты

Чеклист

  • Красный линтер витрины валит job
  • CHANGELOG — при релизе

@Ibochkarev Ibochkarev added javascript Pull requests that update javascript code priority: medium Средний приоритет tech-debt Maintainability / refactor / architecture debt labels Sep 8, 2026
@Ibochkarev
Ibochkarev requested a review from biz87 September 8, 2026 10:02
Add ESLint flat config for plain <script> globals, CI step that fails
on warnings, and clear accumulated style/unused-catch findings (#667).
@Ibochkarev
Ibochkarev force-pushed the fix/issue-667-storefront-eslint branch from b2f1ec9 to 9155b16 Compare September 9, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code priority: medium Средний приоритет tech-debt Maintainability / refactor / architecture debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI не линтует JS витрины (assets/components/minishop3/js/web)

1 participant