Repository navigation
Fix session group refresh 3713 - #3722
Closed
abhay-2108 wants to merge 2 commits into
Closed
abhay-2108 wants to merge 2 commits into
abhay-2108 wants to merge 2 commits into
Conversation
…odelcontextprotocol#3713) - Evict previous components registered by a session before aggregating new catalog - Exclude session's own components from duplicate collision checks - Guard exit stack cleanup against KeyError for caller-owned sessions - Update docs/client/session-groups.md to document connect_with_session refresh behavior - Add comprehensive tests asserting full internal and public invariants
- Preserve existing components when MCPError occurs during refresh - Retain exit stack for group-owned sessions with empty catalogs so disconnect cleans them up - Retain original public-Client repro alongside mock-based tests - Document failed-fetch refresh preservation in session-groups docs
Contributor
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and this PR doesn't link an open issue yet.
You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
help wanted, or I'm a maintainer)Additional context