Repository navigation
fix(observability): redact wf.result in strict mode - #639
Draft
mistralai-nfau wants to merge 1 commit into
Draft
mistralai-nfau wants to merge 1 commit into
mistralai-nfau wants to merge 1 commit into
Conversation
AttributeRedactionPolicy matched on attribute-name fragments, and 'result' was missing from DEFAULT_SENSITIVE_ATTRIBUTE_FRAGMENTS. Activity and workflow outputs (wf.result) were exported unredacted even with OTEL_REDACTION=strict, while wf.arguments was masked. The model reply masked on the chat span (gen_ai.output.messages) thus leaked in clear on the activity span. Add 'result' to the default sensitive fragments and cover wf.arguments/wf.result with a regression test. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"result"toDEFAULT_SENSITIVE_ATTRIBUTE_FRAGMENTSsoAttributeRedactionPolicymaskswf.result(activity/workflow outputs) alongsidewf.argumentswhenOTEL_REDACTION=strictstrictmode maskedwf.argumentsbut exportedwf.resultunredacted — meaning the model reply masked on thechatspan (gen_ai.output.messages) leaked in clear on the model-call activity'swf.result{"wf.arguments": "x", "wf.result": "x"}→ both[REDACTED]Bug report
OTEL_REDACTION=strictdoesn't redactwf.result.AttributeRedactionPolicymatches on attribute-name fragments, and"result"was missing fromDEFAULT_SENSITIVE_ATTRIBUTE_FRAGMENTS.Affected versions: mistralai 2.9.4 / workflows 3.11.0, still present in 3.2.0 / 3.16.0.
Verification
pytest src/mistralai/extra/tests/test_redaction_policies.py— 51 passedclient-tswith 48 passing tests