Repository navigation
[P2] Restore CI and release gates by formatting the reviewer workflow #116
Description
Ask: Format the AI reviewer workflow with the repository's configured Prettier so CI and the Release Please test gate pass again.
Expected files: .github/workflows/ai-pr-review.yaml
Problem:
The reviewer v3 migration merged in PR #115 leaves its workflow failing the existing formatting check. This is not just cosmetic: the latest main-branch Release Please run fails its Lint and Test job and skips both Release Please and Build and Push Docker Image. The same formatting failure also affects PR CI. Restore the existing check rather than weakening or bypassing it.
Evidence:
- Verified default-branch revision:
d38384ed2886572a7997552a3905b4f73618b66c(2026-09-30)..github/workflows/ai-pr-review.yaml:60-64uses double-quoted input strings, while.prettierrc.js:6setssingleQuote: true; the full workflow is the file identified by the failing formatter. package.json:9defineslint:checkasprettier . --check --config=.prettierrc.js --ignore-path=.prettierignore --ignore-path=.gitignore;tooling/.check.exs:26includes that command inmix check..github/workflows/ci.yml:85-86and.github/workflows/release-please.yml:74-75both runmix check --no-fix --no-retry. The release-please job depends ontestat.github/workflows/release-please.yml:80.- Main run https://github.com/misospace/pinchflat/actions/runs/36785104846 has the exact revision above. Its log says
[warn] .github/workflows/ai-pr-review.yaml,Code style issues found in the above file, andprettier_formatting error code 1. Compiler, Credo, ExUnit, Elixir formatter, mix_audit and Sobelow all report success. GitHub reports Lint and Test failed, Release Please skipped, and Build and Push Docker Image skipped. - PR ci: move the AI reviewer to pr-reviewer-action v3.0.0 #115 CI run https://github.com/misospace/pinchflat/actions/runs/36784394728 also failed. Open PR release: 1.4.7 #114 is the existing release PR, not a workflow formatting fix. Searches of open/closed issues for
prettier,formatting, andai-pr-review.yamlfound no issue covering this regression. Closed issue [P1] release-please PR #57 stuck for ~24 days, blocking 11+ merged fixes (incl. security) from shipping #106 concerned the older bot-token/action_required release failure fixed before this revision, not this new formatter failure.
Acceptance:
- Format
.github/workflows/ai-pr-review.yamlwith the existing repository Prettier configuration without changing action pins, inputs, permissions, or review behavior. yarn run lint:checkpasses;mix check --no-fix --no-retrypasses in the supported CI environment.- A subsequent main-branch Release Please run passes Lint and Test and no longer skips the Release Please job because of this formatting failure. No merge or administrative branch-protection changes are required by this issue.
Activity
itsmiso-ai commentedon Oct 2, 2026
Already fixed on
main— no code change needed, so no PR is possible (the formatter reports no diff to make).What landed:
5d55c745acec4df1fcec7acd937f88927d2f9c1a—chore(ci): format AI review workflow (#131), merged 2026-10-01T03:12:54Z — switched the four double-quoted inputs at.github/workflows/ai-pr-review.yaml:60-64(ci-timeout-sec,tool-allowed-gh-api-repos,claim-falsification,allow-approve) to the single quotes required by.prettierrc.js. Values, action pins, permissions and review behavior are unchanged; the only later edit to that file,f991445(#135), added two more inputs already in single-quote style.Verified against current
main(ce2e227059e9beddbbb2c359eb2a27c386589dc4):yarn run lint:check(Prettier 3.9.6, pinned inpackage.json) → "All matched files use Prettier code style!"success(including theprettier_formattingcheck insidemix check), Release Pleasesuccess— no longer skipped. Build and Push Docker Image isskippedonly because no release was cut, which is normal.This issue duplicates #130, which #131 closed as
Fixes #130. Closing as duplicate.itsmiso-ai commentedon Oct 2, 2026
Courier: already addressed (run courier-e687840997ae082dbab04f937a07ee5f)
Issue #116's formatting regression was already fixed on main by 5d55c74 'chore(ci): format AI review workflow (#131)' (merged 2026-10-01T03:12:54Z), which converted the four double-quoted inputs at .github/workflows/ai-pr-review.yaml:60-64 to the single quotes required by .prettierrc.js (values, pins, permissions, behavior unchanged); #131 closed the duplicate issue #130. Verified at current main head ce2e227: 'yarn run lint:check' (Prettier 3.9.6) reports 'All matched files use Prettier code style!', so there is no diff to open a PR from. Release Please run https://github.com/misospace/pinchflat/actions/runs/36960956547 on that revision shows Lint and Test success and the Release Please job success (no longer skipped); Build and Push Docker Image is skipped only because no release was cut. Every main-branch Release Please run since the fix is green (runs 36877566747, 36877607154, 36899373391, 36900348146, 36936026804). No open PR targets this (only release PR #114). Issue #116 commented with this evidence and closed as a duplicate of #130; run branch courier/misospace/pinchflat/issue-116 has no commits beyond origin/main.