Skip to content

Remove ignored network isolation policy from pipelines - #14728

Open
Sean McManus (sean-mcmanus) wants to merge 1 commit into
mainfrom
seanmcm/devbox2-wsl/agent155/fix-defaultdeny-policy-warning
Open

Remove ignored network isolation policy from pipelines#14728
Sean McManus (sean-mcmanus) wants to merge 1 commit into
mainfrom
seanmcm/devbox2-wsl/agent155/fix-defaultdeny-policy-warning

Conversation

@sean-mcmanus

Copy link
Copy Markdown
Contributor

Summary

Removes the incompatible Permissive network isolation policy from the component-governance, extension-pack, and themes pipelines. The effective CFSClean, CFSClean2, and CFSClean3 policies remain enabled.

This PR was investigated and created by GitHub Copilot (in VS Code). Any message starting with ✨Copilot: was sent by Copilot.

Root cause

#14284 retained Permissive while enabling CFSClean3. The current 1ES DefaultDeny policy ignores Permissive as incompatible, producing a warning without changing effective network isolation.

Fix

Pass only the compatible CFS policies to 1ES network isolation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused configuration changes consistently remove only the ignored policy.

Pull request overview

Removes the incompatible Permissive network isolation policy while retaining all effective CFS policies.

Changes:

  • Updates component-governance, extension-pack, and themes pipelines.
  • Retains CFSClean, CFSClean2, and CFSClean3.
File summaries
File Description
Build/cg/cg.yml Updates component-governance isolation policies.
Build/package/cpptools_extension_pack.yml Updates extension-pack isolation policies.
Build/package/cpptools_themes.yml Updates themes isolation policies.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sean-mcmanus
Sean McManus (sean-mcmanus) marked this pull request as ready for review September 2, 2026 16:10
@sean-mcmanus
Sean McManus (sean-mcmanus) requested a review from a team as a code owner September 2, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pull Request

Development

Successfully merging this pull request may close these issues.

3 participants