Repository navigation
[docs] Update glossary - weekly full scan - #11579
Amaury Levé (Evangelink) merged 2 commits into
Conversation
Add MSTEST0087 (duplicate DataRow display name) and MSTest.Windows.UIAutomation entries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The MSTEST0087 entry incorrectly implies whitespace-only display names are analyzed.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds glossary documentation for MSTEST0087 and MSTest.Windows.UIAutomation.
Changes:
- Documents duplicate DataRow display-name analysis.
- Documents Windows UI Automation SDK integration.
🟢 Confidence at a glance
Documentation was verified against the implementations and linked PRs.
| File | Description |
|---|---|
docs/glossary.md |
Adds both glossary entries. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
Review outcome: No actionable findings — both new glossary entries are factually accurate and well-formed.
Change classification
- Documentation: Adds two glossary entries (
docs/glossary.md) — MSTEST0087 (duplicate DataRow display name) analyzer and theMSTest.Windows.UIAutomationpackage.
Confidence at a glance
🟢 Correctness & design (Documentation Accuracy) — verified against source
- Why it applies: This is a documentation-only PR; dimension 17 (Documentation Accuracy) is the only applicable review dimension.
- Evidence:
DuplicateDataRowDisplayNameAnalyzer(src/Analyzers/MSTest.Analyzers/DuplicateDataRowDisplayNameAnalyzer.cs) confirms:DiagnosticSeverity.Warning,isEnabledByDefault: true,HashSet<string>(StringComparer.Ordinal)for the ordinal/case-sensitive comparison, andstring.IsNullOrWhiteSpace(displayName)skip logic that excludes rows without an explicit non-emptyDisplayName. The full test suite (DuplicateDataRowDisplayNameAnalyzerTests.cs) exercises exactly the behaviors described (no-diagnostic on missing/null/empty/whitespace names, case-sensitivity, interleaved duplicates, derivedTestMethodAttribute, cross-method independence). PR #11409 is merged and matches ("Add analyzer for duplicate DataRow display names").MSTest.Windows.UIAutomation:src/Package/MSTest.Sdk/Sdk/Features/WindowsUIAutomation.targetsconfirms the build-timeTargetPlatformIdentifier != 'windows'error, thePackageReference, and the implicitusinggated onImplicitUsings.Sdk.props.templateconfirmsEnableWindowsUIAutomationdefaults tofalse(opt-in) andMSTestWindowsUIAutomationVersiondefaults to$(Version)(the MSTest.Sdk version). PR #10862 is merged and matches ("Add MSTest.Windows.UIAutomation for desktop UI tests").- Cross-reference
[MSTest.Sdk](#mstestsdk)anchor resolves to the existing### MSTest.Sdkheading; both new entries follow the same phrasing/formatting conventions (backticks, "Introduced in [PR #...]" pattern) used by neighboring entries, and their placement follows the glossary's existing "MSTEST00xx before MSTest" and dotted-name ordering convention already established for prior entries.
- Gap or disposition: No discrepancies found between the prose and the analyzer/MSBuild implementation or test coverage.
⚪ Not applicable: Concurrency & lifecycle, Security & protocol, API & compatibility, Performance, Localization, Tests, Analyzers, Build/dependencies/scripts (no non-.md files changed).
Clarified the definition of the MSTest analyzer regarding duplicate DataRow display names, specifying that non-blank DisplayNames are considered. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Add MSTEST0087 (duplicate DataRow display name) and MSTest.Windows.UIAutomation entries.
Fixes #11570