Skip to content

[docs] Update glossary - weekly full scan - #11579

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
glossary-update-daily-20260928-89c8f5e2c7300e17
Sep 29, 2026
Merged

Amaury Levé (Evangelink) merged 2 commits into
mainfrom
glossary-update-daily-20260928-89c8f5e2c7300e17

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Add MSTEST0087 (duplicate DataRow display name) and MSTest.Windows.UIAutomation entries.

Fixes #11570

Add MSTEST0087 (duplicate DataRow display name) and MSTest.Windows.UIAutomation entries.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 28, 2026 06:41
@github-actions github-actions Bot added the state/needs-review Awaiting review from the team. label Sep 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The MSTEST0087 entry incorrectly implies whitespace-only display names are analyzed.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Adds glossary documentation for MSTEST0087 and MSTest.Windows.UIAutomation.

Changes:

  • Documents duplicate DataRow display-name analysis.
  • Documents Windows UI Automation SDK integration.
🟢 Confidence at a glance

Documentation was verified against the implementations and linked PRs.

File Description
docs/​glossary.md Adds both glossary entries.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/glossary.md Outdated
@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Sep 28, 2026
@github-actions github-actions Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Sep 28, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review outcome: No actionable findings — both new glossary entries are factually accurate and well-formed.

Change classification

  • Documentation: Adds two glossary entries (docs/glossary.md) — MSTEST0087 (duplicate DataRow display name) analyzer and the MSTest.Windows.UIAutomation package.

Confidence at a glance

🟢 Correctness & design (Documentation Accuracy) — verified against source
  • Why it applies: This is a documentation-only PR; dimension 17 (Documentation Accuracy) is the only applicable review dimension.
  • Evidence:
    • DuplicateDataRowDisplayNameAnalyzer (src/Analyzers/MSTest.Analyzers/DuplicateDataRowDisplayNameAnalyzer.cs) confirms: DiagnosticSeverity.Warning, isEnabledByDefault: true, HashSet<string>(StringComparer.Ordinal) for the ordinal/case-sensitive comparison, and string.IsNullOrWhiteSpace(displayName) skip logic that excludes rows without an explicit non-empty DisplayName. The full test suite (DuplicateDataRowDisplayNameAnalyzerTests.cs) exercises exactly the behaviors described (no-diagnostic on missing/null/empty/whitespace names, case-sensitivity, interleaved duplicates, derived TestMethodAttribute, cross-method independence). PR #11409 is merged and matches ("Add analyzer for duplicate DataRow display names").
    • MSTest.Windows.UIAutomation: src/Package/MSTest.Sdk/Sdk/Features/WindowsUIAutomation.targets confirms the build-time TargetPlatformIdentifier != 'windows' error, the PackageReference, and the implicit using gated on ImplicitUsings. Sdk.props.template confirms EnableWindowsUIAutomation defaults to false (opt-in) and MSTestWindowsUIAutomationVersion defaults to $(Version) (the MSTest.Sdk version). PR #10862 is merged and matches ("Add MSTest.Windows.UIAutomation for desktop UI tests").
    • Cross-reference [MSTest.Sdk](#mstestsdk) anchor resolves to the existing ### MSTest.Sdk heading; both new entries follow the same phrasing/formatting conventions (backticks, "Introduced in [PR #...]" pattern) used by neighboring entries, and their placement follows the glossary's existing "MSTEST00xx before MSTest" and dotted-name ordering convention already established for prior entries.
  • Gap or disposition: No discrepancies found between the prose and the analyzer/MSBuild implementation or test coverage.

⚪ Not applicable: Concurrency & lifecycle, Security & protocol, API & compatibility, Performance, Localization, Tests, Analyzers, Build/dependencies/scripts (no non-.md files changed).

@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Sep 28, 2026
@github-actions github-actions Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Sep 28, 2026
Clarified the definition of the MSTest analyzer regarding duplicate DataRow display names, specifying that non-blank DisplayNames are considered.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 28, 2026 07:26
@github-actions github-actions Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Sep 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation accurately reflects the implemented features and configuration.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@Evangelink
Amaury Levé (Evangelink) merged commit 4569438 into main Sep 29, 2026
14 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the glossary-update-daily-20260928-89c8f5e2c7300e17 branch September 29, 2026 06:48
@github-actions github-actions Bot removed the state/needs-review Awaiting review from the team. label Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Update glossary - weekly full scan

2 participants