Repository navigation
Fix Unix pipe timeout test failure by handling ConnectionReset exception - #11184
Closed
Amaury Levé (Evangelink) wants to merge 33 commits into
Closed
Amaury Levé (Evangelink) wants to merge 33 commits into
Amaury Levé (Evangelink) wants to merge 33 commits into
Conversation
…10950) Co-authored-by: Copilot <amauryleve@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…l/4.4) (#10955) Co-authored-by: Amaury Levé <amauryleve@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…to rel/4.4) (#10962) Co-authored-by: Amaury Levé <amauryleve@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ort to rel/4.4) (#10986) Co-authored-by: Copilot <amauryleve@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…(backport to rel/4.4) (#10984) Co-authored-by: Amaury Levé <amauryleve@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…port to rel/4.4) (#11005) Co-authored-by: Amaury Levé <amauryleve@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… rel/4.4) (#11008) Co-authored-by: Amaury Levé <amauryleve@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
(backport to rel/4.4) (#11036) Co-authored-by: Amaury Levé <amauryleve@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 63c25c36-0fb9-4605-86fa-e2152aa7588b
…ackport to rel/4.4) (#11091) Co-authored-by: Amaury Levé <amauryleve@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 63c25c36-0fb9-4605-86fa-e2152aa7588b
…(backport to rel/4.4) (#11117) Co-authored-by: Amaury Levé <amauryleve@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 63c25c36-0fb9-4605-86fa-e2152aa7588b
…of graceful disconnect) by @Evangelink in #11113 (backport to rel/4.4) (#11150) Co-authored-by: Amaury Levé <amauryleve@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Related to #4774 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Unix systems can report a forced close of an idle pipe as a connection reset instead of EOF. The test was failing on Linux with .NET 9.0 because it didn't handle this exception. This change adds a try-catch block to handle the IOException with ConnectionReset SocketError, which is the expected behavior on Unix when a pipe is closed abruptly. This fixes the failing test ServerDisposal_WhenClientConnectsWithoutSendingRequest_DoesNotHang in the Linux Release build. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Closing in favor of pushing the fix directly to the existing backport PR #11180. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The stated scope does not match the release-wide patch, and the MSBuild asset copies can race across parallel target-framework builds.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (3)
| Severity | Finding |
|---|---|
src/Platform/Microsoft.Testing.Platform.MSBuild/Microsoft.Testing.Platform.MSBuild.csproj — This target runs once per inner target framework, and the project targets several frameworks.… |
|
eng/install-access-database-engine.ps1 — This now leaves the downloaded installer in the repository working directory on both success and… |
|
eng/Versions.props — The PR description says this is limited to handling ConnectionReset in one cancellation test, but… |
What changed in this PR
The PR contains the Unix pipe-disposal test fix, but also a broad set of unrelated release, API, build, telemetry, localization, and pipeline changes.
Changes:
- Handles controller shutdown, response-file expansion, telemetry, and reporting behavior.
- Updates experimental API documentation and shipped API baselines.
- Revises build infrastructure, localization resources, dependencies, and release versions.
| File | Description |
|---|---|
test/UnitTests/Microsoft.Testing.Platform.UnitTests/TestHostBuilderTests.cs |
Tests final shutdown-timeout configuration. |
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Messages/AsynchronousMessageBusTests.cs |
Serializes a timing-sensitive test. |
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TestCommandLineOptions.cs |
Supports passive option defaults. |
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/RetryTests.cs |
Tests response-file fallback warnings. |
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsTestResultsClientHandlerTests.cs |
Tests redirect and decompression settings. |
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AppInsightsProviderTests.cs |
Tests dedicated telemetry-thread startup. |
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/TestHostProcessLifetimeHandlerTests.cs |
Increases disposal-test timing allowance. |
test/Directory.Build.targets |
Persists the failed-result display default. |
src/TestFramework/TestFramework/InternalAPI/InternalAPI.Unshipped.txt |
Clears shipped internal API entries. |
src/TestFramework/TestFramework/Interfaces/ITestDataSourceEmptyDataSourceExceptionInfo.cs |
Documents experimental status. |
src/TestFramework/TestFramework/Filtering/TestFilterResult.cs |
Documents experimental status and BOM. |
src/TestFramework/TestFramework/Filtering/TestFilterContext.cs |
Documents experimental status and BOM. |
src/TestFramework/TestFramework/Filtering/TestFilterAction.cs |
Documents experimental status and BOM. |
src/TestFramework/TestFramework/Filtering/ITestFilter.cs |
Documents experimental status and BOM. |
src/TestFramework/TestFramework/Attributes/TestMethod/RetryResult.cs |
Documents experimental status. |
src/TestFramework/TestFramework/Attributes/TestMethod/RetryContext.cs |
Documents experimental status. |
src/TestFramework/TestFramework/Attributes/TestMethod/RetryBaseAttribute.cs |
Documents experimental retry execution. |
src/TestFramework/TestFramework/Attributes/Lifecycle/TestFilterProviderAttributeOfT.cs |
Documents experimental status. |
src/TestFramework/TestFramework/Attributes/Lifecycle/TestFilterProviderAttribute.cs |
Documents experimental status and BOM. |
src/TestFramework/TestFramework/Assertions/Assert.StringDifference.cs |
Restricts caret rendering for whitespace mismatches. |
src/TestFramework/TestFramework/Assertions/Assert.Scope.cs |
Documents experimental status and BOM. |
src/TestFramework/TestFramework/Assertions/Assert.AddValueFormatter.cs |
Documents experimental overloads and BOM. |
src/TestFramework/TestFramework.Extensions/TestRun.cs |
Documents experimental status. |
src/TestFramework/TestFramework.Extensions/TestContext.cs |
Documents experimental current context. |
src/TestFramework/TestFramework.Extensions/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt |
Removes shipped API from unshipped baseline. |
src/TestFramework/TestFramework.Extensions/PublicAPI/netstandard2.0/PublicAPI.Shipped.txt |
Ships TestTempDirectory. |
src/TestFramework/TestFramework.Extensions/PublicAPI/net9.0/PublicAPI.Unshipped.txt |
Removes shipped API from unshipped baseline. |
src/TestFramework/TestFramework.Extensions/PublicAPI/net9.0/PublicAPI.Shipped.txt |
Ships TestTempDirectory. |
src/TestFramework/TestFramework.Extensions/PublicAPI/net8.0/PublicAPI.Unshipped.txt |
Removes shipped API from unshipped baseline. |
src/TestFramework/TestFramework.Extensions/PublicAPI/net8.0/PublicAPI.Shipped.txt |
Ships TestTempDirectory. |
src/TestFramework/TestFramework.Extensions/PublicAPI/net462/PublicAPI.Unshipped.txt |
Removes shipped API from unshipped baseline. |
src/TestFramework/TestFramework.Extensions/PublicAPI/net462/PublicAPI.Shipped.txt |
Ships TestTempDirectory. |
src/TestFramework/TestFramework.Extensions/PlannedTest.cs |
Documents experimental status. |
src/TestFramework/TestFramework.Extensions/ITestRunInfo.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Tools/IToolsManager.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Tools/IToolCommandLineOptionsProvider.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Tools/ITool.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/TestHostOrchestrator/ITestHostOrchestratorManager.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/TestHostOrchestrator/ITestHostOrchestratorExtension.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/TestHostOrchestrator/ITestHostOrchestratorApplicationLifetime.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/TestHostOrchestrator/ITestHostExecutionOrchestrator.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/TestHostControllers/TestHostLaunchContext.cs |
Documents experimental status and BOM. |
src/Platform/Microsoft.Testing.Platform/TestHostControllers/ITestHostLauncher.cs |
Documents experimental status and BOM. |
src/Platform/Microsoft.Testing.Platform/TestHostControllers/ITestHostHandle.cs |
Documents experimental status and BOM. |
src/Platform/Microsoft.Testing.Platform/TestHostControllers/ITestHostControllerManager.cs |
Documents experimental launcher methods. |
src/Platform/Microsoft.Testing.Platform/TestHostControllers/ITestHostControllerConnectionAuthorizer.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/TestFramework/ExecuteRequestContext.cs |
Documents experimental constructor. |
src/Platform/Microsoft.Testing.Platform/Services/ServiceProviderExtensions.cs |
Documents experimental service accessors. |
src/Platform/Microsoft.Testing.Platform/Services/IPlatformInformation.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Services/IClientInfo.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Services/IClientCapabilities.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Services/ExecutableInfo.cs |
Tracks original and expanded arguments. |
src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs |
Adds the close-channel control message. |
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.cs |
Exposes the recursive-response-file resource. |
src/Platform/Microsoft.Testing.Platform/Requests/TreeNodeFilter/TreeNodeFilter.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Requests/TestExecutionRequestOrigin.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Requests/TestExecutionRequestKind.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Requests/TestExecutionFilterOperator.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Requests/TestExecutionFilterContext.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Requests/ITestExecutionFilterProvider.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Requests/IExecuteRequestCompletionNotifier.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Requests/CompositeTestExecutionFilter.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.Initialization.cs |
Applies passive result-visibility defaults. |
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterCommandLineOptionsProvider.cs |
Reads explicit or default visibility. |
src/Platform/Microsoft.Testing.Platform/Messages/ShutdownTimeouts.cs |
Parses timeout values directly. |
src/Platform/Microsoft.Testing.Platform/Logging/ILoggingManager.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Logging/ILoggerProvider.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostControllersTestHost.ProcessConfiguration.cs |
Configures the control pipe and timeout. |
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostControllersTestHost.Ipc.cs |
Reuses resolved pipe identities. |
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.Utilities.cs |
Creates the child cancellation listener. |
src/Platform/Microsoft.Testing.Platform/Helpers/TestApplicationBuilderExtensions.cs |
Documents experimental APIs. |
src/Platform/Microsoft.Testing.Platform/Helpers/System/IClock.cs |
Documents experimental internal API. |
src/Platform/Microsoft.Testing.Platform/Helpers/EnvironmentVariableConstants.cs |
Adds the control-pipe variable. |
src/Platform/Microsoft.Testing.Platform/Extensions/IBlockingDataConsumer.cs |
Documents experimental status and BOM. |
src/Platform/Microsoft.Testing.Platform/Extensions/ArtifactPostProcessing/IArtifactPostProcessingManager.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Configurations/IHierarchicalConfigurationProvider.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Configurations/IConfigurationSource.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Configurations/IConfigurationProvider.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Configurations/IConfigurationManager.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/CommandLine/ParseResult.cs |
Stores expanded response-file arguments. |
src/Platform/Microsoft.Testing.Platform/CommandLine/Parser.cs |
Replaces response-file tokens during expansion. |
src/Platform/Microsoft.Testing.Platform/CommandLine/OptionRecord.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/CommandLine/ICommandLineManager.cs |
Documents experimental provider registration. |
src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsProviderBase.cs |
Documents experimental internal API. |
src/Platform/Microsoft.Testing.Platform/Capabilities/TestFramework/TestFrameworkCapabilitiesExtensions.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Capabilities/TestFramework/IGracefulStopTestExecutionCapability.cs |
Documents experimental capabilities. |
src/Platform/Microsoft.Testing.Platform/Capabilities/TestFramework/IBannerMessageOwnerCapability.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform/Builder/TestApplication.cs |
Propagates expanded arguments. |
src/Platform/Microsoft.Testing.Platform/Builder/ITestApplicationBuilder.cs |
Documents experimental properties. |
src/Platform/Microsoft.Testing.Platform/Builder/IArtifactPostProcessingApplicationBuilder.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform.ServerMode.Client.Sources/Client/MtpJsonRpcConnection.cs |
Supports nonblocking read-loop disposal. |
src/Platform/Microsoft.Testing.Platform.MSBuild/Microsoft.Testing.Platform.MSBuild.csproj |
Changes package-layout asset copies. |
src/Platform/Microsoft.Testing.Platform.AI/IChatClientProvider.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Platform.AI/ChatClientProviderExtensions.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Extensions.VideoRecorder/VideoRecorderExtensions.cs |
Documents experimental status and BOM. |
src/Platform/Microsoft.Testing.Extensions.VideoRecorder/InternalAPI/InternalAPI.Unshipped.txt |
Clears shipped internal APIs. |
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.zh-Hant.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.tr.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.pt-BR.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.ko.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.it.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/xlf/ExtensionResources.fr.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.TrxReport/Resources/ExtensionResources.resx |
Refines localization locks. |
src/Platform/Microsoft.Testing.Extensions.TrxReport.Abstractions/PublicAPI/PublicAPI.Unshipped.txt |
Removes shipped APIs from unshipped baseline. |
src/Platform/Microsoft.Testing.Extensions.TrxReport.Abstractions/PublicAPI/PublicAPI.Shipped.txt |
Ships work-item property APIs. |
src/Platform/Microsoft.Testing.Extensions.Telemetry/InternalAPI/InternalAPI.Unshipped.txt |
Clears shipped internal APIs. |
src/Platform/Microsoft.Testing.Extensions.Telemetry/InternalAPI/InternalAPI.Shipped.txt |
Ships telemetry internals. |
src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs |
Uses a dedicated .NET Framework ingest thread. |
src/Platform/Microsoft.Testing.Extensions.PackagedApp/PublicAPI/PublicAPI.Unshipped.txt |
Clears shipped public APIs. |
src/Platform/Microsoft.Testing.Extensions.PackagedApp/PublicAPI/PublicAPI.Shipped.txt |
Updates packaged-app shipped APIs. |
src/Platform/Microsoft.Testing.Extensions.OpenTelemetry/PublicAPI/PublicAPI.Unshipped.txt |
Clears shipped public APIs. |
src/Platform/Microsoft.Testing.Extensions.OpenTelemetry/PublicAPI/PublicAPI.Shipped.txt |
Updates OpenTelemetry shipped APIs. |
src/Platform/Microsoft.Testing.Extensions.Logging/MicrosoftExtensionsLoggingBuilderExtensions.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Extensions.JUnitReport/Resources/xlf/ExtensionResources.zh-Hant.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.JUnitReport/Resources/xlf/ExtensionResources.tr.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.JUnitReport/Resources/xlf/ExtensionResources.pt-BR.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.JUnitReport/Resources/xlf/ExtensionResources.ko.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.JUnitReport/Resources/xlf/ExtensionResources.it.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.JUnitReport/Resources/xlf/ExtensionResources.fr.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.JUnitReport/Resources/ExtensionResources.resx |
Refines localization locks. |
src/Platform/Microsoft.Testing.Extensions.JUnitReport/JUnitReportExtensions.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Extensions.HtmlReport/Resources/xlf/ExtensionResources.zh-Hant.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.HtmlReport/Resources/xlf/ExtensionResources.tr.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.HtmlReport/Resources/xlf/ExtensionResources.pt-BR.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.HtmlReport/Resources/xlf/ExtensionResources.ko.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.HtmlReport/Resources/xlf/ExtensionResources.it.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.HtmlReport/Resources/xlf/ExtensionResources.fr.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.HtmlReport/Resources/ExtensionResources.resx |
Refines localization locks. |
src/Platform/Microsoft.Testing.Extensions.HtmlReport/HtmlReportExtensions.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Extensions.HotReload/InternalAPI/InternalAPI.Unshipped.txt |
Updates internal API baseline. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/PublicAPI/PublicAPI.Unshipped.txt |
Clears shipped public APIs. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/PublicAPI/PublicAPI.Shipped.txt |
Updates shipped reporting APIs. |
src/Platform/Microsoft.Testing.Extensions.CtrfReport/Resources/xlf/ExtensionResources.zh-Hant.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CtrfReport/Resources/xlf/ExtensionResources.tr.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CtrfReport/Resources/xlf/ExtensionResources.ru.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CtrfReport/Resources/xlf/ExtensionResources.pt-BR.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CtrfReport/Resources/xlf/ExtensionResources.ko.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CtrfReport/Resources/xlf/ExtensionResources.it.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CtrfReport/Resources/xlf/ExtensionResources.fr.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CtrfReport/Resources/xlf/ExtensionResources.cs.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CtrfReport/Resources/ExtensionResources.resx |
Refines localization locks. |
src/Platform/Microsoft.Testing.Extensions.CtrfReport/CtrfReportExtensions.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hant.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hans.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.tr.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ru.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pt-BR.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pl.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ko.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ja.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.it.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.fr.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.es.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.de.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlf |
Regenerates localization metadata. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/CrashDumpResources.resx |
Refines localization locks. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/InternalAPI/InternalAPI.Unshipped.txt |
Clears shipped internal APIs. |
src/Platform/Microsoft.Testing.Extensions.AzureFoundry/TestApplicationBuilderExtensions.cs |
Documents experimental status. |
src/Platform/Microsoft.Testing.Extensions.AzureFoundry/PublicAPI/PublicAPI.Unshipped.txt |
Removes shipped API entry. |
src/Platform/Microsoft.Testing.Extensions.AzureFoundry/PublicAPI/PublicAPI.Shipped.txt |
Ships credential overload. |
src/Platform/Microsoft.Testing.Extensions.AzureFoundry/InternalAPI/InternalAPI.Unshipped.txt |
Clears shipped internal APIs. |
src/Platform/Microsoft.Testing.Extensions.AzureFoundry/InternalAPI/InternalAPI.Shipped.txt |
Ships provider internals. |
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/Resources/AzureDevOpsResources.resx |
Adds authentication/content-type diagnostics. |
src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsExtensions.cs |
Injects logging into the REST client. |
src/Package/MSTest.Sdk/Sdk/Runner/NativeAOT.targets |
Corrects the retry warning. |
src/Analyzers/MSTest.SourceGeneration/Generators/TestClassModelBuilder.cs |
Supports closed generic base types. |
src/Analyzers/MSTest.SourceGeneration/Generators/ReflectionMetadataGenerator.cs |
Roots closed referenceable bases. |
src/Analyzers/MSTest.SourceGeneration/AnalyzerReleases.Unshipped.md |
Clears released analyzer entries. |
src/Analyzers/MSTest.SourceGeneration/AnalyzerReleases.Shipped.md |
Records the 4.4 analyzer release. |
src/Adapter/MSTestAdapter.PlatformServices/SourceGeneration/SourceGeneratedReflectionOperations.cs |
Updates trimming documentation and BOM. |
src/Adapter/MSTestAdapter.PlatformServices/PublicAPI/PublicAPI.Unshipped.txt |
Clears shipped reflection-hook APIs. |
src/Adapter/MSTest.TestAdapter/buildTransitive/uwp/MSTest.TestAdapter.targets |
Filters UWP satellite resources. |
NuGet.config |
Removes redundant package mappings. |
eng/Versions.props |
Advances product and coverage versions. |
eng/validate-affected-tests.ps1 |
Validates branch-selected affected-test mode. |
eng/pipelines/steps/test-windows-configuration-tests.yml |
Removes cached Debug runtime preparation. |
eng/install-access-database-engine.ps1 |
Changes installer download lifecycle. |
docs/affected-test-selection.md |
Documents the shared pipeline call site. |
Directory.Packages.props |
Removes MSBuild cache packages. |
.github/workflows/shared/build-failure-analysis-fetch.md |
Updates build-log comments. |
.github/copilot-instructions.md |
Adds experimental API documentation rules. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+104
to
+107
| <Copy SourceFiles="@(MSBuildAssetsBuildTargeting)" DestinationFiles="@(MSBuildAssetsBuildTargeting->'$(ArtifactsDir)tests/nugetPackageFolder/$(AssemblyName)/buildMultiTargeting/%(RecursiveDir)%(Filename)%(Extension)')" /> | ||
|
|
||
| <Message Text="MSBuildAssetsBuildTransitive tests: @(MSBuildAssetsBuildTransitive->'$(ArtifactsDir)tests/nugetPackageFolder/$(AssemblyName)/buildTransitive/%(RecursiveDir)%(Filename)%(Extension)')" Importance="low" /> | ||
| <Copy SourceFiles="@(MSBuildAssetsBuildTransitive)" DestinationFiles="@(MSBuildAssetsBuildTransitive->'$(ArtifactsDir)tests/nugetPackageFolder/$(AssemblyName)/buildTransitive/%(RecursiveDir)%(Filename)%(Extension)')" Condition=" '$(TargetFramework)' == 'netstandard2.0' " /> | ||
| <Copy SourceFiles="@(MSBuildAssetsBuildTransitive)" DestinationFiles="@(MSBuildAssetsBuildTransitive->'$(ArtifactsDir)tests/nugetPackageFolder/$(AssemblyName)/buildTransitive/%(RecursiveDir)%(Filename)%(Extension)')" /> |
Comment on lines
+6
to
+7
| Invoke-RestMethod https://download.microsoft.com/download/3/5/C/35C84C36-661A-44E6-9324-8786B8DBE231/accessdatabaseengine_X64.exe -OutFile ./accessdatabaseengine_X64.exe | ||
| Start-Process ./accessdatabaseengine_X64.exe -Wait -ArgumentList "/quiet /passive /norestart" |
Comment on lines
+4
to
+6
| <VersionPrefix>4.4.1</VersionPrefix> | ||
| <!-- Testing Platform version --> | ||
| <TestingPlatformVersionPrefix>2.4.0</TestingPlatformVersionPrefix> | ||
| <TestingPlatformVersionPrefix>2.4.1</TestingPlatformVersionPrefix> |
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR fixes a test failure in the Linux Release build for PR #11180 (backport of #11152 to rel/4.4).
Problem
The test
ServerDisposal_WhenClientConnectsWithoutSendingRequest_DoesNotHanginTestHostControllerCancellationTests.cswas failing on Linux with .NET 9.0 with the following error:Root Cause
On Unix systems (Linux), when a pipe is forcefully closed, the system reports it as a "connection reset" error instead of returning EOF (0 bytes). The test was not handling this expected behavior.
Solution
Updated the test to wrap the read operation in a try-catch block that catches
IOExceptionwith theConnectionResetsocket error code. This allows the test to pass on both:Changes
ServerDisposal_WhenClientConnectsWithoutSendingRequest_DoesNotHang()method intest/UnitTests/Microsoft.Testing.Platform.UnitTests/Hosts/TestHostControllerCancellationTests.csTask.WhenAnyto ensure disposal completes without hangingRelated PRs