Skip to content

Fix ESRP publish stage condition to use stageDependencies expression - #5967

Open
David Michon (dmichon-msft) with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-condition-evaluation
Open

Fix ESRP publish stage condition to use stageDependencies expression#5967
David Michon (dmichon-msft) with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-condition-evaluation

Conversation

Copilot AI commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

The Publish stage's condition referenced job outputs using the dependencies. syntax, which is only valid at the job level. At the stage level, this expression silently evaluates to false, causing the stage to be skipped even when the version bump merge check should pass.

Fix

  • Changed the condition on the Publish${{ parameters.StageNameSuffix }} stage to use stageDependencies.Prepare${{ parameters.StageNameSuffix }}.PrepareNpmPublish.outputs['FindBumpRun.IsVersionBumpMerge'], matching the syntax already used for the BumpPipelineRunId/BumpPipelineDefinitionId variables defined later in the same job.
# before
condition: and(succeeded('Prepare${{ parameters.StageNameSuffix }}'), eq(dependencies.Prepare${{ parameters.StageNameSuffix }}.outputs['PrepareNpmPublish.FindBumpRun.IsVersionBumpMerge'], 'true'))

# after
condition: and(succeeded('Prepare${{ parameters.StageNameSuffix }}'), eq(stageDependencies.Prepare${{ parameters.StageNameSuffix }}.PrepareNpmPublish.outputs['FindBumpRun.IsVersionBumpMerge'], 'true'))

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs triage

Development

Successfully merging this pull request may close these issues.

3 participants