Migrate Node.js general options to Unified Settings - #2559
Draft
Matteo Prosperi (matteo-prosperi) wants to merge 1 commit into
Draft
Migrate Node.js general options to Unified Settings#2559Matteo Prosperi (matteo-prosperi) wants to merge 1 commit into
Matteo Prosperi (matteo-prosperi) wants to merge 1 commit into
Conversation
Register the three legacy general options with full bidirectional string migration, refresh unmodified cached values before launch, and add focused compatibility tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Bug
The legacy Node.js Tools > General options page is not registered with Visual Studio Unified Settings. Its three string-backed boolean values can also remain stale in the cached
DialogPageafter an external settings update.Fix
WaitOnAbnormalExit,WaitOnNormalExit, andEditAndContinueunderdebugging.nodejs.generalwith their existing defaults and localized labels.VsUserSettingsRegistrymigration for the existingNodejsTools\Options\General\*string values and associate legacy pageEF677A38-0953-39C2-A228-2FBE8F8F082E.GeneralOptionsPagemutations used by existing consumers.Testing
NodejsGeneralOptionsTestspass.Nodejs.csprojandNodejsToolsVsix.csprojRelease builds pass with the installed VS 18 toolchain (GeneratePkgDefFile=falseavoids an unrelated local CreatePkgDef dependency-resolution failure).registration.schema.jsondraft-07 schema.UnifiedSettings.pkgdefandUnifiedSettings/NodejsGeneralOptions.registration.jsonat the registered paths.NodejsTools.vsmanprojdependency build remains blocked locally by pre-existingTestAdapterImplVS SDK reference failures; the Node.js Tools component JSON was generated and references the validated VSIX payload.