[Bundle] Track complexity by fhibf · Pull Request #5926 · microsoft/fhir-server

Fernando Henrique Inocêncio Borba Ferreira (fhibf) · 2026-10-15T20:46:04Z

Description

Tracking the complexity of bundles with BundleHandlerComplexyCalculator. Different aspects of bundles are considered as part of the complexity calculation.

Additionally, this complexity is now included as part of the latency metric (as a dimension).

Other changes I've made:

Promoted a private class to internal: BundleHandlerInternalOperationExecutionContext
Removed BundleEndpointMetricEmitterAttribute, now the latency signal is emitted from BundleHandler.
Delete tests related to BundleEndpointMetricEmitterAttribute (as this component was removed).
Add tests around the bundle complexity calculation.

Related issues

Addresses AB#209754.

Testing

Describe how this change was tested.

FHIR Team Checklist

Update the title of the PR to be succinct and less than 65 characters
Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
CI is green before merge
Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Copilot

🟡 Changes recommended

The calculator tests contain a compilation error, empty payload fixtures, and incorrect boundary inputs.

4 open findings

Use 99 requests to cross the Medium score threshold · New
Use 99 requests and populate the body stream · New
Populate the request body stream for payload tests · New
Pass the required ILogger argument · New

What changed in this PR

Adds bundle complexity tracking to Microsoft FHIR Server’s processing statistics and latency metrics.

Changes:

Calculates complexity from operation counts, execution mode, and payload sizes.
Moves latency emission into the bundle handler and adds a complexity dimension.
Adds calculator tests and updates existing metric assertions.

File	Description
src/Microsoft.Health.Fhir.Shared.Api/Microsoft.Health.Fhir.Shared.Api.projitems	Registers new bundle classes; removes metric filter.
src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleHandlerStatistics.cs	Includes complexity in statistics.
src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleHandlerParallelOperations.cs	Uses extracted execution context.
src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleHandlerInternalOperationExecutionContext.cs	Extracts operation context into a class.
src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleHandlerComplexityCalculator.cs	Implements complexity scoring.
src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleHandler.cs	Calculates complexity and emits latency.
src/Microsoft.Health.Fhir.Shared.Api/Features/Filters/Metrics/BundleEndpointMetricEmitterAttribute.cs	Removes endpoint latency filter.
src/Microsoft.Health.Fhir.Shared.Api/Controllers/FhirController.cs	Removes bundle metric attribute.
src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Microsoft.Health.Fhir.Shared.Api.UnitTests.projitems	Registers calculator and relocated tests.
src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Features/Resources/Bundle/FhirTransactionFailedExceptionTests.cs	Relocates transaction exception tests.
src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Features/Resources/Bundle/BundleHandlerTests.cs	Checks handler latency emission.
src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Features/Resources/Bundle/BundleHandlerStatisticsTests.cs	Supplies complexity to statistics.
src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Features/Resources/Bundle/BundleHandlerComplexityCalculatorTests.cs	Adds scoring and boundary tests.
src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Features/Filters/Metrics/MetricEmitterAttributeTests.cs	Removes obsolete bundle filter test.
src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Controllers/FhirControllerTests.cs	Removes obsolete attribute assertion.
src/Microsoft.Health.Fhir.Core/Models/BundleComplexity.cs	Defines four complexity levels.
src/Microsoft.Health.Fhir.Core/Logging/Metrics/Handlers/DefaultBundleMetricHandler.cs	Tags latency measurements with complexity.
src/Microsoft.Health.Fhir.Core/Logging/Metrics/BundleMetricNotification.cs	Adds complexity and validates elapsed time.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…exity score.

New tests to validate profile refreshes.

Mikael Weaver (mikaelweave) · 2026-10-16T17:26:00Z

+                    _profilesResolver,
+                    _logger);
+            }
+            catch (InvalidOperationException e)


nit - could combine the exception statements as the message is the same.

Fernando Henrique Inocêncio Borba Ferreira (fhibf) · 2026-10-19T14:12:38Z

/azp run

azure-pipelines · 2026-10-19T14:12:56Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Fernando Henrique Inocêncio Borba Ferreira (fhibf) added 2 commits October 15, 2026 16:24

Classsifying bundles by complexity

15a69d3

Bundle complexity

cc5b307

Fernando Henrique Inocêncio Borba Ferreira (fhibf) added this to the FY27\Q2\2Wk\2Wk08 milestone Oct 15, 2026

Fernando Henrique Inocêncio Borba Ferreira (fhibf) requested a review from a team as a code owner October 15, 2026 20:46

github-advanced-security Bot found potential problems Oct 15, 2026

View reviewed changes

Comment thread src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleHandler.cs Dismissed

Fernando Henrique Inocêncio Borba Ferreira (fhibf) and others added 8 commits October 15, 2026 17:31

Potential fix for pull request finding 'CodeQL / Generic catch clause'

a3dd4dd

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

New change to isolate the logic to detect complex bundles.

9d25d45

New dimention to track bunde complexity.

0b96401

Bundle complexity score.

6614280

Test improvements.

62fca9b

Merge branch 'main' of https://github.com/microsoft/fhir-server

896c4e7

Merge branch 'main' into user/fhibf/bundleComplexity

d99aa6e

Improvements on complexity calculation.

4adc194

Fernando Henrique Inocêncio Borba Ferreira (fhibf) requested a balanced review from Copilot October 16, 2026 16:22

Copilot started reviewing on behalf of Fernando Henrique Inocêncio Borba Ferreira (fhibf) October 16, 2026 16:23

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Fernando Henrique Inocêncio Borba Ferreira (fhibf) added 2 commits October 16, 2026 12:39

Following PR suggestions. Adding profile refresh as part of the compl…

5dd494c

…exity score.

Adding missing test Traits

6d3fe7a

Abigail Nicolas (abiisnn) reviewed Oct 16, 2026

View reviewed changes

Expanding the complexity of bundles as part of the BundleResponseInfo.

f631fb1

New tests to validate profile refreshes.

Abigail Nicolas (abiisnn) previously approved these changes Oct 16, 2026

View reviewed changes

Following PR suggestions.

0fd17dd

Fernando Henrique Inocêncio Borba Ferreira (fhibf) dismissed Abigail Nicolas (abiisnn)’s stale review via 0fd17dd October 16, 2026 21:52

Removing extra-spaces.

0cbbb9e

Mikael Weaver (mikaelweave) approved these changes Oct 16, 2026

View reviewed changes

Fernando Henrique Inocêncio Borba Ferreira (fhibf) enabled auto-merge (squash) October 16, 2026 22:26

Navigation Menu

Repository navigation

[Bundle] Track complexity - #5926

[Bundle] Track complexity#5926
Fernando Henrique Inocêncio Borba Ferreira (fhibf) wants to merge 15 commits into
mainfrom
user/fhibf/bundleComplexity

Fernando Henrique Inocêncio Borba Ferreira (fhibf) commented Oct 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mikael Weaver (mikaelweave) Oct 16, 2026

Uh oh!

Fernando Henrique Inocêncio Borba Ferreira (fhibf) commented Oct 19, 2026

Uh oh!

azure-pipelines Bot commented Oct 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Fernando Henrique Inocêncio Borba Ferreira (fhibf) commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Testing

FHIR Team Checklist

Semver Change (docs)

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mikael Weaver (mikaelweave) Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

Fernando Henrique Inocêncio Borba Ferreira (fhibf) commented Oct 19, 2026

Uh oh!

azure-pipelines Bot commented Oct 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Fernando Henrique Inocêncio Borba Ferreira (fhibf) commented Oct 15, 2026 •

edited

Loading