Fix job attachment 401s for submitted jobs by v-elegacheva · Pull Request #773 · microsoft/azure-quantum-python

v-elegacheva · 2026-09-18T00:00:09Z

Summary

Fixes job attachment operations failing with 401 ClientAuthenticationError after submission.

upload_attachment, download_attachment, and list_attachments now fetch a fresh SAS-signed URI for the job's actual linked container instead of reusing the unsigned details.container_uri. Custom container names and explicit container URI overrides remain supported.

Testing

Added regression coverage for upload, list, and download with unsigned job details.
Added coverage for custom container names and explicit URI overrides.
Full suite: 108 passed, 18 skipped.
Verified clean compatibility with Update autogenerated client #772: the combined suite passes, and Update autogenerated client #772 supplies the generated /jobs/{jobId} update route.

- upload_attachment, download_attachment, and list_attachments in base_job.py were reusing the unsigned container_uri returned by job creation instead of always fetching a fresh SAS-signed URI via workspace.get_container_uri(), causing 401 NoAuthenticationInformation errors. - build_services_jobs_update_request in the generated _operations.py used the wrong URL path segment 'jobUpdateOptions' (the request model type name) instead of 'jobs', causing workspace.update_job() to fail with 404 Not Found.

azure-pipelines · 2026-09-18T00:00:22Z

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

v-elegacheva · 2026-09-18T17:41:19Z

/azp run

azure-pipelines · 2026-09-18T17:41:30Z

Azure Pipelines: Successfully started running 1 pipeline(s).

v-elegacheva · 2026-09-18T17:46:05Z

/azp run

azure-pipelines · 2026-09-18T17:46:14Z

Azure Pipelines: Successfully started running 1 pipeline(s).

v-elegacheva · 2026-09-18T17:58:15Z

/azp run

azure-pipelines · 2026-09-18T17:58:24Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

🟡 Changes recommended

Attachment methods now target the wrong container for jobs created with a custom container name.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Fixes attachment authentication failures and the incorrect job-update endpoint.

Changes:

Refreshes SAS-signed attachment container URIs.
Corrects job PATCH requests to use /jobs/{jobId}.
Adds regression tests for both fixes.

File summaries

File	Description
`base_job.py`	Refreshes attachment container SAS URIs.
`_operations.py`	Corrects the job update route.
`test_job_attachments.py`	Tests attachment URI handling.
`test_workspace.py`	Tests the PATCH resource path.

Review details

Suppressed comments (2)

azure-quantum/azure/quantum/job/base_job.py:381

This selects the default job-{id} container rather than the container encoded in self._details.container_uri. Jobs created with a custom container_name will therefore download from the wrong location. Request the fresh SAS using self.container_name and update the test expectation accordingly.

            container_uri = self.workspace.get_container_uri(job_id=self.id)

azure-quantum/azure/quantum/job/base_job.py:400

Listing now ignores the job's actual linked container name and always targets job-{id}. This breaks list_attachments() for the supported custom-container flow in from_input_data; obtain the fresh SAS for self.container_name and cover that case in the attachment tests.

        container_uri = self.workspace.get_container_uri(job_id=self.id)

Files reviewed: 4/4 changed files
Comments generated: 1
Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

v-elegacheva · 2026-09-18T18:33:59Z

/azp run

azure-pipelines · 2026-09-18T18:34:09Z

Azure Pipelines: Successfully started running 1 pipeline(s).

v-elegacheva · 2026-09-18T18:45:50Z

/azp run

azure-pipelines · 2026-09-18T18:45:59Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

🟡 Changes recommended

Caller-supplied containers from different storage accounts can be redirected to same-named workspace containers.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (2)

azure-quantum/azure/quantum/job/base_job.py:387

For jobs created with from_storage_uri(..., container_uri=...) against another storage account, this re-signs only the extracted container name in the workspace's configured account. The download then reads a different container rather than the job's explicitly linked one. Preserve a usable explicit job-level URI, or restrict workspace SAS refresh to URIs known to be in workspace storage.

            container_uri = self.workspace.get_container_uri(
                job_id=self.id,
                container_name=self.container_name,
            )

azure-quantum/azure/quantum/job/base_job.py:409

This loses the storage-account identity from a caller-supplied job container_uri: get_container_uri selects the workspace-linked/configured account using only the name. Consequently, list_attachments() can list an unrelated same-named container (or create and list an empty one) instead of the explicit container retained by from_storage_uri. Preserve a usable explicit URI or verify the account before refreshing its SAS through the workspace.

        container_uri = self.workspace.get_container_uri(
            job_id=self.id,
            container_name=self.container_name,
        )

Files reviewed: 2/2 changed files
Comments generated: 1
Review effort level: Balanced

v-elegacheva · 2026-09-21T18:15:13Z

/azp run

azure-pipelines · 2026-09-21T18:15:22Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

Copilot review overview

🟡 Changes recommended

Connection-string workspaces still generate SAS tokens without list permission, leaving list_attachments broken.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

Container SAS lacks list permission for explicit storage connections · New

Resolved since last review (1)

from_storage_uri(..., container_uri=...) accepts and stores a caller-supplied output container…

v-elegacheva · 2026-09-21T18:30:49Z

/azp run

azure-pipelines · 2026-09-21T18:31:00Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

Copilot review overview

🟢 Approval recommended

The attachment operations now handle unsigned and unusable SAS URIs with focused regression coverage.

Review effort: Balanced
Findings: 1

Open (1)

Container SAS lacks list permission for explicit storage connections

v-elegacheva requested a review from a team as a code owner September 18, 2026 00:00

v-elegacheva marked this pull request as draft September 18, 2026 17:45

Update tests for fresh attachment SAS URIs

9a57ae5

v-elegacheva requested a balanced review from Copilot September 18, 2026 18:25

Copilot started reviewing on behalf of v-elegacheva September 18, 2026 18:25 View session

Copilot AI reviewed Sep 18, 2026

View reviewed changes

Comment thread azure-quantum/azure/quantum/job/base_job.py Outdated

Preserve custom attachment container names

36790fc

Zulfat Nutfullin (rigidit) reviewed Sep 18, 2026

View reviewed changes

Comment thread azure-quantum/azure/quantum/_client/operations/_operations.py

Leave generated client updates to PR 772

06992ac

v-elegacheva changed the title ~~Fix upload/download/list attachment 401s and job update 404~~ Fix job attachment 401s for submitted jobs Sep 18, 2026

Zulfat Nutfullin (rigidit) requested a balanced review from Copilot September 18, 2026 19:23

Copilot started reviewing on behalf of Zulfat Nutfullin (rigidit) September 18, 2026 19:24 View session

Copilot AI reviewed Sep 18, 2026

View reviewed changes

Comment thread azure-quantum/azure/quantum/job/base_job.py Outdated

v-elegacheva added 3 commits September 21, 2026 10:49

Merge branch 'main' into ekaterina/sdk-job-update-e2e

67c980b

Safely select attachment container SAS URI

59a3d74

Refresh attachment SAS when permissions are insufficient

bf19c4b

v-elegacheva requested a balanced review from Copilot September 21, 2026 18:23

Copilot started reviewing on behalf of v-elegacheva September 21, 2026 18:24 View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Comment thread azure-quantum/azure/quantum/job/base_job.py

Allow listing with connection-string container SAS

5611049

v-elegacheva requested a balanced review from Copilot September 21, 2026 18:31

Copilot started reviewing on behalf of v-elegacheva September 21, 2026 18:32 View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Conversation

v-elegacheva commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Related

Uh oh!

azure-pipelines Bot commented Sep 18, 2026

Uh oh!

v-elegacheva commented Sep 18, 2026

Uh oh!

azure-pipelines Bot commented Sep 18, 2026

Uh oh!

v-elegacheva commented Sep 18, 2026

Uh oh!

azure-pipelines Bot commented Sep 18, 2026

Uh oh!

v-elegacheva commented Sep 18, 2026

Uh oh!

azure-pipelines Bot commented Sep 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (2)

Uh oh!

Uh oh!

v-elegacheva commented Sep 18, 2026

Uh oh!

azure-pipelines Bot commented Sep 18, 2026

Uh oh!

Uh oh!

v-elegacheva commented Sep 18, 2026

Uh oh!

azure-pipelines Bot commented Sep 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (2)

Uh oh!

Uh oh!

v-elegacheva commented Sep 21, 2026

Uh oh!

azure-pipelines Bot commented Sep 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

v-elegacheva commented Sep 21, 2026

Uh oh!

azure-pipelines Bot commented Sep 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

v-elegacheva commented Sep 18, 2026 •

edited

Loading