Skip to content

Fix dynamic rollout hook module registration - #644

Open
Newman Gao (bozarnr) wants to merge 2 commits into
microsoft:mainfrom
bozarnr:fix/hooks-module-registration
Open

Newman Gao (bozarnr) wants to merge 2 commits into
microsoft:mainfrom
bozarnr:fix/hooks-module-registration

Conversation

@bozarnr

Copy link
Copy Markdown

Summary

  • assign each resolved hook path a stable module name and register it in sys.modules before execution
  • restore a prior registration if hook execution raises
  • add a regression test using a temporary hook file with postponed dataclass annotations, a RolloutCreate transformation, and pickle round-tripping

Validation

  • added focused tests/test_hooks.py
  • GitHub Actions will run the repository test matrix on this pull request

Copilot AI balanced review requested due to automatic review settings October 15, 2026 18:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants