fix: allow text after section name in _section_present - #275
Closed
RohithPariki wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing — the maintainer direction confirmed in #175 is to add opt-in section_contains operator rather than modify _section_present. This 1-line change would silently alter scores for existing task sets, which is exactly what maintainers want to avoid. Will reopen with the correct additive approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175. This PR removes the
\s*$anchor from the regex injudges._section_present. Previously, this strict anchor caused the check to fail on headings that contained numbering, annotations, or subtitles (e.g.### 1. Key Risks (Риски) — обзор). By removing the anchor, we ensure that as long as the expected section name is present in a heading, the format is accepted.