Skip to content

No Attribution #2

Description

@mourner

The code was copied from https://github.com/mourner/simplify-js, but you don't seem to attribute both the original repo and the author anywhere in the simplify repos. Not cool.

Activity

  1. ForbesLindesay commented on Mar 23, 2015

    @ForbesLindesay
    Contributor

    It was not intentional. https://github.com/microjs/simplify-base was forked from simplify-js and then Attribution was not maintained properly for the other components. I'll add you as a maintainer and you are welcome to add attribution to the readme files in the manner you would like.

  2. mourner commented on Mar 23, 2015

    @mourner
    Author

    Ah, sorry, missed this one!
    I'm in the process of rewriting simplify-js with browserify & modularity in mind, so found this in npmjs search since it takes up the "simplify" word. :)

  3. ForbesLindesay commented on Mar 23, 2015

    @ForbesLindesay
    Contributor

    Unfortunately, this is not actually the module in npm and I don't have control over the npm module. For that you would need @tj but I'm sure he would happily give you permission since you wrote the original code and he is not actively maintaining his fork. You can follow the instructions on https://docs.npmjs.com/misc/disputes to get the simplify name from him. He just needs to run npm owner add mourner simplify to give you ownership of the module.

    I have added you as an owner on simplify-3d, simplify-2d and simplify-base. If you make any breaking changes to the api they expose, make sure you increment the major version number. Other than that, do with as you please :)

  4. mourner commented on Mar 23, 2015

    @mourner
    Author

    Thanks! I'll look into pinging @tj :)

  5. tj commented on Mar 23, 2015

    @tj

    added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions