Drop structure highlighting runs with a zero-width header - #1321
Merged
Conversation
A document starting with a colon recovers as a compound statement whose
header is a zero-length error node:
":\n pass\n" TryStatement children: ⚠(0,0) Body(0,11)
"if a:\n pass\n" IfStatement children: if(0,2) VariableName(3,4) Body(4,15)
start and bodyStart are then both 0, so positionsForNode asked
skipBodyTrailers for position -1 and doc.lineAt threw. That accounts for
4181 events in Sentry since April 2024, the largest single group in the
project, and it is still present in v3.1.11.
Skip this shape as we cannot meaningfully render it.
Fixes #1318
|
Preview build will be at |
Collaborator
Author
|
So far as I can tell the only impact of this is the logged errors and stale structure highlighting. Worst case is pasting a repro over a doc with existing structure highlighting. |
microbit-matt-hillsdon
deleted the
structure-highlighting-error-node
branch
September 10, 2026 08:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A document starting with a colon recovers as a compound statement whose header is a zero-length error node:
start and bodyStart are then both 0, so positionsForNode asked skipBodyTrailers for position -1 and doc.lineAt threw. That accounts for 4181 events in Sentry since April 2024, the largest single group in the project, and it is still present in v3.1.11.
Skip this shape as we cannot meaningfully render it.
Fixes #1318