[mobt-1285] - Add gridded distance to feature ancil generation for ml precip project - #2452
Open
jdjonathandavies wants to merge 9 commits into
Open
jdjonathandavies wants to merge 9 commits into
jdjonathandavies wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: mobt-1285
As an IMPROVER scientist I would like to be able to supply the [ML Precipitation project] (https://github.com/MetOffice/ml_improver_calibration) with an additional distance to ocean / coast ancillary for gridded data. The data scientists working on this project have been supplied with a land mask ancillary and precipitation data on gridded cubes, and want to use distance to ocean / coast as an additional feature for their ML model.
The current ancillary generation code handles spot cubes for distance to feature, so it will require some modification to be able to produce the same for gridded data.
There is an accompanying PR in
improver_auxthat runs the ancillary generation code.Acceptance criteria
Solution
DistanceToFeatureplugin to be able to work on gridded cubesn x mgrid)Testing