Skip to content

Flag boards whose GPS is wired by the maker as oemFixed - #153

Closed
jamesarich wants to merge 1 commit into
masterfrom
feat/oem-fixed-hardware
Closed

jamesarich wants to merge 1 commit into
masterfrom
feat/oem-fixed-hardware

Conversation

@jamesarich

@jamesarich jamesarich commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Adds oemFixed to deviceHardware so clients can hide diy_only settings (the GPS RX/TX/EN pins) on boards where the maker wired the GPS, and show them everywhere else. A board missing the flag fails open and keeps its pins, per #dev3.

Flagged 18 boards whose firmware variant names an on-board GNSS chip (u-blox, L76K, UC6580) or wires a built-in one with HAS_GPS 1: T-Beam, T-Beam Supreme, T-Beam 1W, T-Beam BPF, T-Echo, T-Echo Plus, T1000-E, WisMesh Tag, Wio WM1110 Tracker, Wio Tracker L1 and L1 E-Ink, Heltec Wireless Tracker V1.1 and V2, MeshTracker X1, ThinkNode M1, Canary One, T-LoRa Pager, T-Deck Pro. T-Deck and T-Watch S3 stay unflagged since their GPS is optional (GPS_DEFAULT_NOT_PRESENT).

Summary by CodeRabbit

  • Improvements
    • Device information now identifies models with manufacturer-wired peripherals. For these devices, DIY-only pin settings can be hidden, so device configuration reflects the hardware available on models including T-Beam, T-Echo, T-Deck Pro, and selected Seeed, Heltec, and RAK devices.

Clients hide `diy_only` settings such as the GPS pins only on these
boards and show them everywhere else, so a board missing the flag
keeps its pins visible. Each flagged board's firmware variant names an
on-board GNSS chip or wires a built-in one.
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a85d4aef-5b0b-4dac-8bb8-cc264c68c455
📥 Commits

Reviewing files that changed from the base of the PR and between c236367 and 381fd31.

📒 Files selected for processing: 1
  • src/lib/resource.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The DeviceHardware interface adds an optional oemFixed flag. Eighteen device entries set the flag to true.

Changes: OEM-fixed device metadata

Layer / File(s) Summary
Add OEM-fixed device metadata
src/lib/resource.ts
DeviceHardware gains the optional oemFixed property. Eighteen device entries set it to true.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Feature

Suggested reviewers: thebentern

Merge Risk: ⚪ Minimal · up to 381fd

The change adds OEM-fixed metadata to the stated 18 board records, while boards without the flag remain unflagged. No actionable merge-blocking risk is established.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: adding the oemFixed flag for boards whose GPS is wired by the manufacturer.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the board by moonlit glow
Eighteen tiny flags now show
Pins stay tucked where makers chose
The rabbit nods, then softly goes
Through fields of code, the changes glow

Comment @coderabbitai help to get the list of available commands.

@jamesarich

Copy link
Copy Markdown
Contributor Author

closing - moving the per-board flag into the protobufs schema as oem_fixed_gps on HardwareModel values, per #dev3

@jamesarich jamesarich closed this Oct 17, 2026
@jamesarich
jamesarich deleted the feat/oem-fixed-hardware branch October 17, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant