Repository navigation
Add Heltec V4 R8 device - #149
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe device hardware list now includes HELTEC_V4_R8 metadata for hardware model 132, including its PlatformIO target, support settings, partition scheme, and image. ChangesHELTEC_V4_R8 Device Support
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The new hardware metadata has no identified merge-blocking issue. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the hardware list Comment |
HELTEC_V4_R8 (hwModel 132) is a revision of the Heltec V4 that needed its own hardware model. Fields mirror the Heltec V4 entry, with the hardware model, slug, platformio target and display name taken from the heltec-v4-r8-oled env in the firmware's variants/esp32s3/heltec_v4_r8/platformio.ini. Requires meshtastic/web-flasher#453, which adds the image.
9db02cf to
bc6faeb
Compare
Adds the Heltec V4 R8 (
hwModel132,HELTEC_V4_R8), a revision of the Heltec V4 that needed its own hardware model.The entry mirrors the Heltec V4 entry, with values taken from the
heltec-v4-r8-oledenv in meshtastic/firmwarevariants/esp32s3/heltec_v4_r8/platformio.ini:hwModelhwModelSlugHELTEC_V4HELTEC_V4_R8platformioTargetheltec-v4heltec-v4-r8-oleddisplayNameimagesheltec_v4.svgheltec_v4_r8_base.svgarchitecture,activelySupported,supportLevel,tags,requiresDfu,hasMuiandpartitionSchemeare the same as the V4.hasMuiistrue, as on the V4. The firmware's R8 env does not declarecustom_meshtastic_has_muiyet, unlike the V4 env; nothing in this repo reads that field.The image name follows the variant's base section,
[heltec_v4_r8_base]. Firmware'scustom_meshtastic_imagesfor this env saysheltec_v4_r8.svg, so the two differ; nothing in this repo reads that field.Depends on meshtastic/web-flasher#453, which adds
public/img/devices/heltec_v4_r8_base.svg. Merge that first, or this image reference points at a missing file.Not included:
heltec-v4-r8-tftenv. The V4's TFT env has no separate entry here either.data/deviceLinks.jsonis synced hourly from msh.to, so R8 links belong there.Verification
pnpm validate: OK, 118 devices (117 before)pnpm biome ci src/lib/resource.ts: cleanpnpm build:data: buildsSummary by CodeRabbit