Repository navigation
Point Wio Tracker L1 Pro 1W at its own device image - #148
Conversation
SEEED_WIO_TRACKER_L1_PRO_1W shared wio_tracker_l1_case.svg with the plain SEEED_WIO_TRACKER_L1, so the two were indistinguishable in the web flasher. Requires meshtastic/web-flasher#451, which adds the image.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesDevice image update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The PRO 1W device now advertises its dedicated image through the resource API, with no identified merge-blocking impact. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the tracker bright Comment |
Points
SEEED_WIO_TRACKER_L1_PRO_1W(hwModel 144) at its own device image.It currently shares
wio_tracker_l1_case.svgwith the plainSEEED_WIO_TRACKER_L1, so the two are indistinguishable in the web flasher. The new artwork carries the Violet body the variant ships in, plus a 1W badge.The filename follows the device's
platformioTarget(seeed_wio_tracker_L1_Pro_1W), lowercased to satisfy the/^[a-z0-9._-]+\.svg$/rule intools/validate.tsand to match the existing files in the flasher's device directory.Depends on meshtastic/web-flasher#451, which adds
public/img/devices/seeed_wio_tracker_l1_pro_1w.svg. That should merge first, or the reference will dangle.The plain
SEEED_WIO_TRACKER_L1entry is unchanged and keepswio_tracker_l1_case.svg.Verification
pnpm validate— OK (117 devices, 222 links, 35 softDevice variants, 4 erase images); it fails on the un-lowercased filename, which is how the casing rule was foundpnpm biome check src/lib/resource.ts— cleanpnpm testfails identically on this branch and on an unmodifiedmastercheckout:tests/worker/router.test.tscannot resolve./generated/documents.js, which is a build artifact absent from a fresh clone. Unrelated to this change, and I did not attempt to fix it.Summary by CodeRabbit