Skip to content

Point Wio Tracker L1 Pro 1W at its own device image - #148

Merged
rcarteraz merged 1 commit into
masterfrom
fix/wio-l1-pro-1w-image
Sep 22, 2026
Merged

rcarteraz merged 1 commit into
masterfrom
fix/wio-l1-pro-1w-image

Conversation

@rcarteraz

@rcarteraz rcarteraz commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Points SEEED_WIO_TRACKER_L1_PRO_1W (hwModel 144) at its own device image.

It currently shares wio_tracker_l1_case.svg with the plain SEEED_WIO_TRACKER_L1, so the two are indistinguishable in the web flasher. The new artwork carries the Violet body the variant ships in, plus a 1W badge.

The filename follows the device's platformioTarget (seeed_wio_tracker_L1_Pro_1W), lowercased to satisfy the /^[a-z0-9._-]+\.svg$/ rule in tools/validate.ts and to match the existing files in the flasher's device directory.

Depends on meshtastic/web-flasher#451, which adds public/img/devices/seeed_wio_tracker_l1_pro_1w.svg. That should merge first, or the reference will dangle.

The plain SEEED_WIO_TRACKER_L1 entry is unchanged and keeps wio_tracker_l1_case.svg.

Verification

  • pnpm validate — OK (117 devices, 222 links, 35 softDevice variants, 4 erase images); it fails on the un-lowercased filename, which is how the casing rule was found
  • pnpm biome check src/lib/resource.ts — clean
  • pnpm test fails identically on this branch and on an unmodified master checkout: tests/worker/router.test.ts cannot resolve ./generated/documents.js, which is a build artifact absent from a fresh clone. Unrelated to this change, and I did not attempt to fix it.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Wio Tracker L1 Pro 1W hardware listing to display the correct device-specific image instead of the casing image.

SEEED_WIO_TRACKER_L1_PRO_1W shared wio_tracker_l1_case.svg with the plain
SEEED_WIO_TRACKER_L1, so the two were indistinguishable in the web flasher.

Requires meshtastic/web-flasher#451, which adds the image.
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e02b7492-74bf-4f69-b925-94a1456aff59

📥 Commits

Reviewing files that changed from the base of the PR and between 2ab630f and ccddf4e.

📒 Files selected for processing (1)
  • src/lib/resource.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The SEEED_WIO_TRACKER_L1_PRO_1W resource entry now references seeed_wio_tracker_l1_pro_1w.svg instead of wio_tracker_l1_case.svg.

Changes

Device image update

Layer / File(s) Summary
Update device image reference
src/lib/resource.ts
The device entry now uses seeed_wio_tracker_l1_pro_1w.svg in its images array.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: thebentern

Merge Risk: ⚪ Minimal · up to ccddf

The PRO 1W device now advertises its dedicated image through the resource API, with no identified merge-blocking impact.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: assigning the Wio Tracker L1 Pro 1W its own device image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the tracker bright
A sharper image comes to sight
The old case fades away
A new device shines today
Hop, hop, clean display!

Comment @coderabbitai help to get the list of available commands.

@rcarteraz
rcarteraz merged commit ed1b38c into master Sep 22, 2026
5 checks passed
@rcarteraz
rcarteraz deleted the fix/wio-l1-pro-1w-image branch September 22, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant