docs: exit stdio tutorials cleanly on EOF - #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README and first-server tutorial passed srv.Run directly to log.Fatal, which exits 1 even when Run returns nil after normal stdin EOF. Handle only non-nil errors.
Verified the tutorial verbatim in a disposable module pinned to published CodeMode v0.2.0 and SDK v1.7.0. Discovery and execution succeeded before the fix, but normal EOF exited 1. The corrected tutorial returns the documented lookup result and exits 0 on EOF. No runtime API or behavior changes.