Update vulnerable development dependencies and require Node 20 - #55
Open
0xBreadguy wants to merge 2 commits into
Open
0xBreadguy wants to merge 2 commits into
0xBreadguy wants to merge 2 commits into
Conversation
Member
Author
|
More cleanup. Features:
Worked with Astra. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
The existing
dependency-checkjob fails on development dependencies already present on main, including the audit failure observed in #54. Update the dependency lockfile and the pinnedbrace-expansionoverride to clear the audit without a major Jest upgrade or changes to token data/generation logic.Changes
brace-expansionoverride from 5.0.6 to 5.0.12. The old exact pin prevented normal audit remediation.npm ciin generation and formatting workflows, matching the existing audit workflow. All CI installs now consume the reviewed lockfile without rewriting it; an inconsistent manifest/lockfile fails instead of resolving new versions.This is a separate maintainer-level dependency PR based on main at
87fe2b0. It does not depend on #54 and can be merged first; #54 will then need to pick up the updated base and rerun its checks. The diff contains dependency settings, the lockfile, the README prerequisite, and the two CI install commands. The minimum stays at Node 20; no runtime upgrade to Node 24 is included.Validation
npm ci --ignore-scripts: successful.npm audit --audit-level=low: zero reported vulnerabilities.551978a, using these updated dependencies on Node 20: all 39 tests and TypeScript pass. Generation produces only the expected Ethereum ETH bridge correction, mainnet 1.0.1, unchanged testnet, and byte-identical files on a second generation.git diff --check: passed.Audit totals can include packages affected transitively and vary with advisory metadata; the acceptance criterion here is a clean audit on the repaired dependency tree.