ci(release): measure every release and commit its benchmark figures - #9
Merged
Merged
Conversation
The macOS arm64 build job runs bench/publish.py against the versioned release binary and uploads the two reports and the rewritten README speed table; the publish job takes them into the release commit. Every published version ships with figures measured on the same class of machine, stamped with its own version, and no older version's numbers survive a release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README speed table must only ever describe the version that ships. Until now
bench/publish.pyhad to be run by hand after a release, so the table lagged one version behind (it currently says 0.5.1 on a 0.5.2 release).aarch64-apple-darwinbuild job runsbench/publish.pyagainst the versioned release binary and uploadsREADME.md,bench/results/content.jsonandbench/results/performance.jsonas abenchmarksartifact.npm run release; the two reports are added to the semantic-release git assets, so the release commit carries this version's figures and table.dist/.Docs updated accordingly.
npm test10/10, workflow YAML parses; the release run for this change is the end-to-end test.