fix: count the README example in bytes, and stop the figures drifting - #6
Merged
Merged
Conversation
The See-it panel said 756 bytes. That is the character count of a view containing multi-byte characters; the byte count is 760. The input and the percentage were already right, and every other figure came from a bench report that counts bytes, so this row was the only wrong one. Counting characters where bytes were meant is easy to do and invisible in review, so scripts/check_readme.py now rebuilds all nine fixtures behind the reduction table, runs the compressor, and fails if any input, output or percentage has drifted. Its own negative case was checked: a deliberately wrong figure exits 1. CI runs it on both platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The See-it panel said 756 bytes, which is the character count of a view containing multi-byte characters. The byte count is 760. The input size and the percentage were already correct, and the other eight rows came from a bench report that counts bytes, so this was the only wrong figure.
Counting characters where bytes were meant is easy to do and invisible in review, so this also adds
scripts/check_readme.py: it rebuilds all nine fixtures behind the reduction table, runs the compressor, and fails if any input, output or percentage has drifted from what the binary produces. The checker's negative case was verified, a deliberately wrong figure exits 1, and CI runs it on both platforms.